From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Amit Kucheria" <amitk@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT v2 3/3] drivers/thermal/rcar_gen3_thermal: add reading fuses for Gen4
Date: Thu, 11 May 2023 21:12:56 +0200 [thread overview]
Message-ID: <ZF0+OIvCcaDGoJ51@shikoro> (raw)
In-Reply-To: <TYBPR01MB53413B97CCBAC486C2CF7085D8609@TYBPR01MB5341.jpnprd01.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 645 bytes --]
> > + priv->ptat[0] = rcar_gen3_thermal_read(priv->tscs[0], REG_GEN4_THSFMON01) &
> > + GEN4_FUSE_MASK;
>
> s/REG_GEN4_THSFMON01/REG_GEN4_THSFMON16/
>
> According to the table in 13.3.3.4 of R-Car {S4,V4H} Hardware manuals:
>
> PTAT1 PTAT_PF_U_SR1 bits (of THSFMON16 register)
> PTAT2 PTAT_PF_R_SR1 bits (of THSFMON17 register)
> PTAT3 PTAT_PF_L_SR1 bits (of THSFMON15 register)
> THCODE1 THCODE_U_SR1 bits (of THSFMON01 register)
> THCODE2 THCODE_R_SR1 bits (of THSFMON02 register)
> THCODE3 THCODE_L_SR1 bits (of THSFMON00 register)
Oops, you are right, I mixed the two blocks :/ I'll send a fixed version
right away!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-05-11 19:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 9:21 [PATCH RFT v2 0/3] drivers/thermal/rcar_gen3_thermal: add Gen4 fuse support Wolfram Sang
2023-04-20 9:21 ` [PATCH RFT v2 1/3] drivers/thermal/rcar_gen3_thermal: introduce 'info' structure Wolfram Sang
2023-04-20 9:21 ` [PATCH RFT v2 2/3] drivers/thermal/rcar_gen3_thermal: refactor reading fuses into seprarate function Wolfram Sang
2023-04-20 9:21 ` [PATCH RFT v2 3/3] drivers/thermal/rcar_gen3_thermal: add reading fuses for Gen4 Wolfram Sang
2023-04-21 8:02 ` Yoshihiro Shimoda
2023-05-11 19:12 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF0+OIvCcaDGoJ51@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=niklas.soderlund@ragnatech.se \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.