From: "Ryan C. Underwood" <nemesis@icequake.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15
Date: Thu, 11 May 2023 12:21:38 -0500 [thread overview]
Message-ID: <ZF0kIsLPs0fzvDXI@icequake.net> (raw)
In-Reply-To: <87ednm4zux.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Thu, May 11, 2023 at 06:06:14PM +0200, Takashi Iwai wrote:
> On Wed, 10 May 2023 18:19:08 +0200,
> Ryan C. Underwood wrote:
> >
> >
> > The Pavilion 15 line has B&O top speakers similar to the x360 and
> > applying the same profile produces good sound. Without this, the sound
> > would be tinny and underpowered without either applying
> > model=alc295-hp-x360 or booting another OS first.
>
> The code change looks OK, but could you give your Signed-off-by tag?
> It's a legal requirement and mandatory for merging to the upstream.
I'll send a new patch with that updated.
> Also, you can reduce the recipients in Cc a bit more.
> For this kind of trivial change, just maintainers and ML should
> suffice.
Sorry, I just used the output of get_maintainer.pl...
--
Ryan C. Underwood, <nemesis@icequake.net>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-05-11 17:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 16:19 [PATCH] snd-hda-intel: Apply HP B&O top speaker profile to Pavilion 15 Ryan C. Underwood
2023-05-11 16:06 ` Takashi Iwai
2023-05-11 17:21 ` Ryan C. Underwood [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-05-11 17:32 Ryan C. Underwood
2023-05-12 8:28 ` Takashi Iwai
2023-05-12 16:42 ` Ryan C. Underwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF0kIsLPs0fzvDXI@icequake.net \
--to=nemesis@icequake.net \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.