From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04414C7EE23 for ; Fri, 12 May 2023 14:34:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683902084; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=/quVNzlDRVI7bztx83eGW0nwodJ/0MupVRp/RbDR9UE=; b=QT8J7jZuKgXrvoKigwAmHHlJNcWfJDEdjgx7YUzH6kzHza0QbkVeLLlXcYocZ6A2gsftlR btaY0j+eqEZ1Du0Xhp9WbH9/YO6qw0750Z3ix6g5CF0ZUkM4UcWN8fktc0jY5d5PBMCcoT Wc1Iuz/p+nuje8kT1rqsWeIXgWVj6CI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-41-riY3cazvM02YWIt71opl1Q-1; Fri, 12 May 2023 10:34:40 -0400 X-MC-Unique: riY3cazvM02YWIt71opl1Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B25031C060EE; Fri, 12 May 2023 14:34:38 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9EE835443; Fri, 12 May 2023 14:34:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9522119451E4; Fri, 12 May 2023 14:34:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1987219451E3 for ; Fri, 12 May 2023 14:34:36 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id F06002026D25; Fri, 12 May 2023 14:34:35 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8E322026D16 for ; Fri, 12 May 2023 14:34:35 +0000 (UTC) Received: from us-smtp-inbound-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CDD3B85C064 for ; Fri, 12 May 2023 14:34:35 +0000 (UTC) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-CkB_rBmrO1uNujsJKuvFig-1; Fri, 12 May 2023 10:34:34 -0400 X-MC-Unique: CkB_rBmrO1uNujsJKuvFig-1 Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-3f38b7ca98aso57244621cf.1 for ; Fri, 12 May 2023 07:34:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683902073; x=1686494073; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3NI8PblGX09aXcegfRrsRbp5Rk8EB7aSb1Q3zVJjhig=; b=coETRGtmtqXUCAek2TH+5xIUe+xOmrHjQd/9x26CiQN8dEZ6R1SLMQavW+bdPOKLJv ShMDex1Ln1BpcyvU/nfAOki/HnhTjbhXI+elarhQObaQT19Ztq+oSxTWJclo1jeBdn02 CK2ooNW5Soetw7Y/xKvVuL3s9IAkZD68FfGjBSNU9l0wKom0jW81jgAZVxxEpbJgMnEo nGA6rKy+refFpTl/FWT6z2DhDByQO9kgO8BW9xbCOANdajDGOfvEYZBPFuOUjhrWRlxQ DdZt1CEA1VNViN6CB9yWlqNqcIKCQ2OEnXPpt0fU7gcIDJxT8LKZlJPpjI+p3k1RCGVO /sVg== X-Gm-Message-State: AC+VfDxyYwdSQnzpX4dO2hSh52Jtn8k3JLwUhj+proHGpTKf905bzMGp Mpigc+VhkxTGHQgsvLVqMj4ShaKxXBksPgnfFgSJ X-Google-Smtp-Source: ACHHUZ4M++aZz9x/idwKRxoZtFqzxE+KBfxysydbhwDNajJOH3TAbWPaBDcqWbbuEGec9dZSQIGwHA== X-Received: by 2002:ac8:5787:0:b0:3f3:91bd:a46d with SMTP id v7-20020ac85787000000b003f391bda46dmr24764787qta.8.1683902073426; Fri, 12 May 2023 07:34:33 -0700 (PDT) Received: from localhost (pool-68-160-166-30.bstnma.fios.verizon.net. [68.160.166.30]) by smtp.gmail.com with ESMTPSA id f8-20020ae9ea08000000b0074d3233487dsm5387535qkg.114.2023.05.12.07.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 07:34:32 -0700 (PDT) Date: Fri, 12 May 2023 10:34:31 -0400 From: Mike Snitzer To: Sarthak Kukreti , Jens Axboe , Brian Foster , "Darrick J. Wong" Message-ID: References: <20230420004850.297045-1-sarthakkukreti@chromium.org> <20230506062909.74601-1-sarthakkukreti@chromium.org> <20230506062909.74601-5-sarthakkukreti@chromium.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Subject: Re: [dm-devel] [PATCH v6 4/5] dm-thin: Add REQ_OP_PROVISION support X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-block@vger.kernel.org, Theodore Ts'o , "Michael S. Tsirkin" , Jason Wang , Bart Van Assche , linux-kernel@vger.kernel.org, Christoph Hellwig , dm-devel@redhat.com, Andreas Dilger , Stefan Hajnoczi , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Alasdair Kergon Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: kernel.org Content-Disposition: inline Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gVGh1LCBNYXkgMTEgMjAyMyBhdCAgNDowM1AgLTA0MDAsClNhcnRoYWsgS3VrcmV0aSA8c2Fy dGhha2t1a3JldGlAY2hyb21pdW0ub3JnPiB3cm90ZToKCj4gT24gVHVlLCBNYXkgOSwgMjAyMyBh dCA5OjU44oCvQU0gTWlrZSBTbml0emVyIDxzbml0emVyQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4K PiA+IE9uIFNhdCwgTWF5IDA2IDIwMjMgYXQgIDI6MjlQIC0wNDAwLAo+ID4gU2FydGhhayBLdWty ZXRpIDxzYXJ0aGFra3VrcmV0aUBjaHJvbWl1bS5vcmc+IHdyb3RlOgo+ID4KPiA+ID4gZG0tdGhp bnBvb2wgdXNlcyB0aGUgcHJvdmlzaW9uIHJlcXVlc3QgdG8gcHJvdmlzaW9uCj4gPiA+IGJsb2Nr cyBmb3IgYSBkbS10aGluIGRldmljZS4gZG0tdGhpbnBvb2wgY3VycmVudGx5IGRvZXMgbm90Cj4g PiA+IHBhc3MgdGhyb3VnaCBSRVFfT1BfUFJPVklTSU9OIHRvIHVuZGVybHlpbmcgZGV2aWNlcy4K PiA+ID4KPiA+ID4gRm9yIHNoYXJlZCBibG9ja3MsIHByb3Zpc2lvbiByZXF1ZXN0cyB3aWxsIGJy ZWFrIHNoYXJpbmcgYW5kIGNvcHkgdGhlCj4gPiA+IGNvbnRlbnRzIG9mIHRoZSBlbnRpcmUgYmxv Y2suIEFkZGl0aW9uYWxseSwgaWYgJ3NraXBfYmxvY2tfemVyb2luZycKPiA+ID4gaXMgbm90IHNl dCwgZG0tdGhpbiB3aWxsIG9wdCB0byB6ZXJvIG91dCB0aGUgZW50aXJlIHJhbmdlIGFzIGEgcGFy dAo+ID4gPiBvZiBwcm92aXNpb25pbmcuCj4gPiA+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFNhcnRo YWsgS3VrcmV0aSA8c2FydGhha2t1a3JldGlAY2hyb21pdW0ub3JnPgo+ID4gPiAtLS0KPiA+ID4g IGRyaXZlcnMvbWQvZG0tdGhpbi5jIHwgNzAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKystLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA2NiBpbnNlcnRpb25zKCspLCA0 IGRlbGV0aW9ucygtKQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZC9kbS10aGlu LmMgYi9kcml2ZXJzL21kL2RtLXRoaW4uYwo+ID4gPiBpbmRleCAyYjEzYzk0OWJkNzIuLjNmOTRm NTNhYzk1NiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9tZC9kbS10aGluLmMKPiA+ID4gKysr IGIvZHJpdmVycy9tZC9kbS10aGluLmMKPiA+ID4gQEAgLTQyODgsNiArNDM0Nyw5IEBAIHN0YXRp YyBpbnQgdGhpbl9jdHIoc3RydWN0IGRtX3RhcmdldCAqdGksIHVuc2lnbmVkIGludCBhcmdjLCBj aGFyICoqYXJndikKPiA+ID4gICAgICAgICAgICAgICB0aS0+bWF4X2Rpc2NhcmRfZ3JhbnVsYXJp dHkgPSB0cnVlOwo+ID4gPiAgICAgICB9Cj4gPiA+Cj4gPiA+ICsgICAgIHRpLT5udW1fcHJvdmlz aW9uX2Jpb3MgPSAxOwo+ID4gPiArICAgICB0aS0+cHJvdmlzaW9uX3N1cHBvcnRlZCA9IHRydWU7 Cj4gPiA+ICsKPiA+Cj4gPiBXZSBuZWVkIHRoaXMgaW4gdGhpbl9jdHI6IHRpLT5tYXhfcHJvdmlz aW9uX2dyYW51bGFyaXR5ID0gdHJ1ZTsKPiA+Cj4gPiBNb3JlIG5lZWRlZCBpbiB0aGUgdGhpbiB0 YXJnZXQgdGhhbiB0aGluLXBvb2w7IG90aGVyd2lzZSBwcm92aXNpb24gYmlvCj4gPiBpc3N1ZWQg dG8gdGhpbiBkZXZpY2VzIHdvbid0IGJlIHNwbGl0IGFwcHJvcHJpYXRlbHkuICBCdXQgSSBkbyB0 aGluawo+ID4gaXRzIGZpbmUgdG8gc2V0IGluIGJvdGggdGhpbl9jdHIgYW5kIHBvb2xfY3RyLgo+ ID4KPiA+IE90aGVyd2lzZSwgbG9va3MgZ29vZC4KPiA+Cj4gVGhhbmtzISBJJ2xsIGFkZCBpdCB0 byB0aGUgbmV4dCBpdGVyYXRpb24gKGluIGFkZGl0aW9uIHRvIGFueSBvdGhlcgo+IGZlZWRiYWNr IHRoYXQncyBhZGRlZCB0byB2NikuCgpPSy4gSSdsbCBiZWdpbiBiYXNpbmcgZG0tdGhpbnAncyBX UklURV9aRVJPRVMgc3VwcG9ydCBvbnRvcCBvZiB0aGlzCnNlcmllcy4KIAo+IEdpdmVuIHRoYXQg dGhpcyBzZXJpZXMgY292ZXJzIG11bHRpcGxlIHN1YnN5c3RlbXMsIHdvdWxkIHRoZXJlIGJlIGEK PiBwcmVmZXJyZWQgd2F5IG9mIHF1ZXVlaW5nIHRoaXMgZm9yIG1lcmdlPwoKSSB0aGluayBpdCdk IGJlIE9LIGZvciBKZW5zIHRvIHBpY2sgdGhpcyBzZXJpZXMgdXAgYW5kIEknbGwgcmViYXNlCm15 IGNvcnJlc3BvbmRpbmcgRE0gdHJlZSBvbmNlIGhlIGRvZXMuCgpJbiBhZGRpdGlvbiB0byBKZW5z OyBCcmlhbiwgRGFycmljayBhbmQvb3Igb3RoZXJzOiBhbnkgY2hhbmNlIHlvdQpjb3VsZCByZXZp ZXcgdGhlIGJsb2NrIGNvcmUgY2hhbmdlcyBpbiB0aGlzIHNlcmllcyB0byBlbnN1cmUgeW91J3Jl CmNvb2wgd2l0aCB0aGVtPwoKV291bGQgYmUgbmljZSB0byBnZXQgU2FydGhhayByZXZpZXcgZmVl ZGJhY2sgc28gdGhhdCBob3BlZnVsbHkgaGlzIHY3CmNhbiBiZSB0aGUgZmluYWwgcmV2aXNpb24u CgpUaGFua3MsCk1pa2UKCi0tCmRtLWRldmVsIG1haWxpbmcgbGlzdApkbS1kZXZlbEByZWRoYXQu Y29tCmh0dHBzOi8vbGlzdG1hbi5yZWRoYXQuY29tL21haWxtYW4vbGlzdGluZm8vZG0tZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF9D4C77B75 for ; Fri, 12 May 2023 14:35:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241252AbjELOfX (ORCPT ); Fri, 12 May 2023 10:35:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241039AbjELOfU (ORCPT ); Fri, 12 May 2023 10:35:20 -0400 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E2AE1733 for ; Fri, 12 May 2023 07:34:34 -0700 (PDT) Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-3f38b7ca98aso57244611cf.1 for ; Fri, 12 May 2023 07:34:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683902073; x=1686494073; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3NI8PblGX09aXcegfRrsRbp5Rk8EB7aSb1Q3zVJjhig=; b=GzHr/GokcxQd+6VYLNA40KXHOnoUvYwGP/qJLJiiDoNRQEZJJcfilGsOhWDt1yPn74 aynLJMFIW5amQpF6jonjTW77g0OYA71eohuCV/7pr96CyZlt5tGK6hEqR13m9xxeQDgY ptzukvWATRxkT6/h0syrtowiFglTsJXEFbqM9pgj4oezbtk/+uVCSyCv6oCSXFZAoFv6 hFneIGmjpdU7eyEyVwZX72007aVcdt5Jr3cmz59R7v9B+V30Sw/qtZXGZJcKXudM+tji w56SkzZPQqQFJP0NJ2ijLlEqnSF6Bj+G6TFD2TUOXMEzXolMefwKXI2BXr3jrQN1V0gC wwPQ== X-Gm-Message-State: AC+VfDwRJlapAb6OzIFesvQzrpPfYM9+aJvedp6/qGsrNOgg3GHrwosA AZQLSd9FNLN30RonWgTHanI0 X-Google-Smtp-Source: ACHHUZ4M++aZz9x/idwKRxoZtFqzxE+KBfxysydbhwDNajJOH3TAbWPaBDcqWbbuEGec9dZSQIGwHA== X-Received: by 2002:ac8:5787:0:b0:3f3:91bd:a46d with SMTP id v7-20020ac85787000000b003f391bda46dmr24764787qta.8.1683902073426; Fri, 12 May 2023 07:34:33 -0700 (PDT) Received: from localhost (pool-68-160-166-30.bstnma.fios.verizon.net. [68.160.166.30]) by smtp.gmail.com with ESMTPSA id f8-20020ae9ea08000000b0074d3233487dsm5387535qkg.114.2023.05.12.07.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 07:34:32 -0700 (PDT) Date: Fri, 12 May 2023 10:34:31 -0400 From: Mike Snitzer To: Sarthak Kukreti , Jens Axboe , Brian Foster , "Darrick J. Wong" Cc: Christoph Hellwig , Theodore Ts'o , "Michael S. Tsirkin" , Jason Wang , Bart Van Assche , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, dm-devel@redhat.com, Andreas Dilger , Stefan Hajnoczi , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Alasdair Kergon Subject: Re: [PATCH v6 4/5] dm-thin: Add REQ_OP_PROVISION support Message-ID: References: <20230420004850.297045-1-sarthakkukreti@chromium.org> <20230506062909.74601-1-sarthakkukreti@chromium.org> <20230506062909.74601-5-sarthakkukreti@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, May 11 2023 at 4:03P -0400, Sarthak Kukreti wrote: > On Tue, May 9, 2023 at 9:58 AM Mike Snitzer wrote: > > > > On Sat, May 06 2023 at 2:29P -0400, > > Sarthak Kukreti wrote: > > > > > dm-thinpool uses the provision request to provision > > > blocks for a dm-thin device. dm-thinpool currently does not > > > pass through REQ_OP_PROVISION to underlying devices. > > > > > > For shared blocks, provision requests will break sharing and copy the > > > contents of the entire block. Additionally, if 'skip_block_zeroing' > > > is not set, dm-thin will opt to zero out the entire range as a part > > > of provisioning. > > > > > > Signed-off-by: Sarthak Kukreti > > > --- > > > drivers/md/dm-thin.c | 70 +++++++++++++++++++++++++++++++++++++++++--- > > > 1 file changed, 66 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c > > > index 2b13c949bd72..3f94f53ac956 100644 > > > --- a/drivers/md/dm-thin.c > > > +++ b/drivers/md/dm-thin.c > > > @@ -4288,6 +4347,9 @@ static int thin_ctr(struct dm_target *ti, unsigned int argc, char **argv) > > > ti->max_discard_granularity = true; > > > } > > > > > > + ti->num_provision_bios = 1; > > > + ti->provision_supported = true; > > > + > > > > We need this in thin_ctr: ti->max_provision_granularity = true; > > > > More needed in the thin target than thin-pool; otherwise provision bio > > issued to thin devices won't be split appropriately. But I do think > > its fine to set in both thin_ctr and pool_ctr. > > > > Otherwise, looks good. > > > Thanks! I'll add it to the next iteration (in addition to any other > feedback that's added to v6). OK. I'll begin basing dm-thinp's WRITE_ZEROES support ontop of this series. > Given that this series covers multiple subsystems, would there be a > preferred way of queueing this for merge? I think it'd be OK for Jens to pick this series up and I'll rebase my corresponding DM tree once he does. In addition to Jens; Brian, Darrick and/or others: any chance you could review the block core changes in this series to ensure you're cool with them? Would be nice to get Sarthak review feedback so that hopefully his v7 can be the final revision. Thanks, Mike