From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Maximilian Weigand <mweigand@mweigand.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH v2 6/6] Input: cyttsp5 - implement proper sleep and wakeup procedures
Date: Mon, 1 May 2023 17:22:23 -0700 [thread overview]
Message-ID: <ZFBXvz17jDhEPI6c@google.com> (raw)
In-Reply-To: <20230501113010.891786-7-mweigand@mweigand.net>
On Mon, May 01, 2023 at 01:30:10PM +0200, Maximilian Weigand wrote:
> struct cyttsp5 {
> struct device *dev;
> struct completion cmd_done;
> + struct completion cmd_command_done;
Why do we need separate comletion? Do you observe some additional
traffic from the controller when powering it off and on?
> +static int __maybe_unused cyttsp5_suspend(struct device *dev)
> +{
> + struct cyttsp5 *ts = dev_get_drvdata(dev);
> +
> + if (!ts->is_wakeup_source)
I believe the idiomatic way to check this is to call
device_may_wakeup().
> + cyttsp5_enter_sleep(ts);
> + return 0;
> +}
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-05-02 0:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 11:30 [PATCH v2 0/6] Small fixes to the cyttsp5 touchscreen driver Maximilian Weigand
2023-05-01 11:30 ` [PATCH v2 1/6] Input: cyttsp5 - fix array length Maximilian Weigand
2023-05-02 0:15 ` Dmitry Torokhov
2023-05-01 11:30 ` [PATCH v2 2/6] Input: cyttsp5 - remove unused code Maximilian Weigand
2023-05-02 0:15 ` Dmitry Torokhov
2023-05-01 11:30 ` [PATCH v2 3/6] dt-bindings: input: cypress,tt21000 - fix interrupt type in dts example Maximilian Weigand
2023-05-02 0:24 ` Dmitry Torokhov
2023-05-02 14:23 ` Maximilian Weigand
2023-05-02 20:51 ` Dmitry Torokhov
2023-05-01 11:30 ` [PATCH v2 4/6] Input: cyttsp5 - properly initialize the device as a pm wakeup device Maximilian Weigand
2023-05-02 0:14 ` Dmitry Torokhov
2023-05-01 11:30 ` [PATCH v2 5/6] dt-bindings: input: cypress,tt21000 - add wakeup-source entry to documentation Maximilian Weigand
2023-05-02 0:28 ` Dmitry Torokhov
2023-05-01 11:30 ` [PATCH v2 6/6] Input: cyttsp5 - implement proper sleep and wakeup procedures Maximilian Weigand
2023-05-02 0:22 ` Dmitry Torokhov [this message]
2023-05-02 14:21 ` Maximilian Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFBXvz17jDhEPI6c@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=alistair@alistair23.me \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mweigand@mweigand.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.