Re: [Intel-xe] [PATCH v2 13/15] TEMPORARY: drm/xe/display: Enable modular fia in TGL

[Rodrigo Vivi <rodrigo.vivi@kernel.org>]

On Tue, Apr 25, 2023 at 12:26:22PM -0700, José Roberto de Souza wrote:
> drm-tip don't have has_modular_fia anymore but to backport it to Xe
> would require us to backport several patches, so this patch is
> intended to only live until next Xe rebase.
> 
> TGL is the first platform tha has it, this is needed to properly
> initialize TC ports in some skus.
> Enabling it for DG1 don't cause any issues as DG1 don't have any real
> TC ports, so intel_tc_port_init() will not be called for DG1.
> 
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>

I would prefer to go without this patch... to avoid temporary patches
and open precedence... but since I'm taking longer than I expected
to start the rebase, let's move with this so we get the proper TC
on some ports like you explained to me in the chat...

I will then remove this on the next rebase.

> ---
>  drivers/gpu/drm/xe/xe_display.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_display.c b/drivers/gpu/drm/xe/xe_display.c
> index 408bd7c8d1c75..fbae60c179be1 100644
> --- a/drivers/gpu/drm/xe/xe_display.c
> +++ b/drivers/gpu/drm/xe/xe_display.c
> @@ -489,7 +489,10 @@ void xe_display_info_init(struct xe_device *xe)
>  	switch (xe->info.platform) {
>  	case XE_TIGERLAKE:
>  	case XE_DG1:
> -		xe->info.display = (struct xe_device_display_info) { GEN12_DISPLAY };
> +		xe->info.display = (struct xe_device_display_info) {
> +			GEN12_DISPLAY,
> +			.has_modular_fia = 1,
> +		};
>  		break;
>  	case XE_ROCKETLAKE:
>  		xe->info.display = (struct xe_device_display_info) {
> -- 
> 2.40.0
>