From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Alban Gruin <alban.gruin@gmail.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] sequencer: rectify empty hint in call of require_clean_work_tree()
Date: Wed, 3 May 2023 09:15:45 +0200 [thread overview]
Message-ID: <ZFIKIXF+nOoC+U1D@ugly> (raw)
In-Reply-To: <64515cff45e03_1ba2d29458@chronos.notmuch>
On Tue, May 02, 2023 at 12:57:03PM -0600, Felipe Contreras wrote:
>Oswald Buddenhagen wrote:
>> if i wanted to be super-pedantic about it, i'd assert that non-null
>> strings are non-empty.
>
>I would disagree. "" is empty but not null, not just in C but in many
>other languages, including shell.
>
yes. that's kinda the point the assert would make.
-- ossi
next prev parent reply other threads:[~2023-05-03 7:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 16:22 [PATCH] sequencer: rectify empty hint in call of require_clean_work_tree() Oswald Buddenhagen
2023-04-27 7:58 ` Oswald Buddenhagen
2023-04-27 21:13 ` Junio C Hamano
2023-04-27 22:33 ` Oswald Buddenhagen
2023-05-02 18:57 ` Felipe Contreras
2023-05-03 7:15 ` Oswald Buddenhagen [this message]
2023-08-07 17:09 ` [PATCH v2] " Oswald Buddenhagen
2023-08-07 20:19 ` Junio C Hamano
2023-08-09 17:15 ` [PATCH v3] " Oswald Buddenhagen
2023-08-09 21:44 ` Junio C Hamano
2023-08-10 11:24 ` Oswald Buddenhagen
2023-08-10 16:04 ` Junio C Hamano
2023-08-24 15:00 ` [PATCH v4] " Oswald Buddenhagen
2023-08-24 15:59 ` Junio C Hamano
2023-08-09 1:24 ` [PATCH v2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFIKIXF+nOoC+U1D@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=alban.gruin@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.