All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Peter Xu <peterx@redhat.com>,
	qemu-block@nongnu.org, Leonardo Bras <leobras@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
	Fam Zheng <fam@euphon.net>, Eric Blake <eblake@redhat.com>,
	John Snow <jsnow@redhat.com>
Subject: Re: [PATCH] migration: Fix block_bitmap_mapping migration
Date: Thu, 4 May 2023 11:40:52 +0200	[thread overview]
Message-ID: <ZFN9pHO659kASsIu@redhat.com> (raw)
In-Reply-To: <20230503181036.14890-1-quintela@redhat.com>

Am 03.05.2023 um 20:10 hat Juan Quintela geschrieben:
> It is valid that params->has_block_bitmap_mapping is true and
> params->block_bitmap_mapping is NULL.  So we can't use the trick of
> having a single function.
> 
> Move to two functions one for each value and the tests are fixed.
> 
> Fixes: b804b35b1c8a0edfd127ac20819c234be55ac7fc
>        migration: Create migrate_block_bitmap_mapping() function
> 
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Juan Quintela <quintela@redhat.com>

Thanks, applied to the block branch.

Kevin



      parent reply	other threads:[~2023-05-04  9:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03 18:10 [PATCH] migration: Fix block_bitmap_mapping migration Juan Quintela
2023-05-03 19:04 ` Vladimir Sementsov-Ogievskiy
2023-05-04  9:40 ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFN9pHO659kASsIu@redhat.com \
    --to=kwolf@redhat.com \
    --cc=eblake@redhat.com \
    --cc=fam@euphon.net \
    --cc=jsnow@redhat.com \
    --cc=leobras@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.