From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Konstantin Kostiuk <kkostiuk@redhat.com>,
Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH] qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601
Date: Thu, 4 May 2023 09:19:17 +0100 [thread overview]
Message-ID: <ZFNqhe6abcx/1Svs@redhat.com> (raw)
In-Reply-To: <20230504075409.121515-1-thuth@redhat.com>
On Thu, May 04, 2023 at 09:54:09AM +0200, Thomas Huth wrote:
> All current versions of glib require _WIN32_WINNT set to 0x0601
> or higher already, and we also use this value as a minimum in our
> osdep.h header file, so there is no way to still compile this code
> with an older version of the Windows ABI. Thus we can drop this
> check now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> qga/commands-win32.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-05-04 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 7:54 [PATCH] qga/commands-win32.c: Drop the check for _WIN32_WINNT >= 0x0601 Thomas Huth
2023-05-04 8:19 ` Daniel P. Berrangé [this message]
2023-05-04 9:02 ` Konstantin Kostiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFNqhe6abcx/1Svs@redhat.com \
--to=berrange@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.