From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FCBBC77B7C for ; Thu, 4 May 2023 13:32:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 70BED212A; Thu, 4 May 2023 15:31:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 70BED212A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683207140; bh=xi0KZeBOnhErsJ04hzAQbP1VsC5piCJgrO5ZBm7URwI=; h=Date:From:To:Subject:References:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=TizfQPBAaJmhp4VcMOn8VyvqSILDvHHsY3320ACo9FxYJb5TTLS0U6ltzak+jGNKT jwBDKK7wyh9sSMv/k+f75sCks7jIA81+UnFycy4XBPyG8H/YmhdN95JK6DBvMgXkKG SXZzmf5ZT6hDZ3M5Ofuu+I2jM0O8Alg7q/9nNBTI= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 2D452F8052D; Thu, 4 May 2023 15:31:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 83C80F8052D; Thu, 4 May 2023 15:31:02 +0200 (CEST) Received: from bluemchen.kde.org (bluemchen.kde.org [209.51.188.41]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3C1C0F80114 for ; Thu, 4 May 2023 15:30:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3C1C0F80114 Received: from ugly.fritz.box (localhost [127.0.0.1]) by bluemchen.kde.org (Postfix) with ESMTP id AF4C323FB4; Thu, 4 May 2023 09:30:57 -0400 (EDT) Received: by ugly.fritz.box (masqmail 0.3.4, from userid 1000) id 1puZ2v-HK2-00; Thu, 04 May 2023 15:30:57 +0200 Date: Thu, 4 May 2023 15:30:57 +0200 From: Oswald Buddenhagen To: Jaroslav Kysela Subject: Re: [PATCH] ALSA: pcm: fix snd_pcm_playback_silence() with free-running mode Message-ID: Mail-Followup-To: Jaroslav Kysela , alsa-devel@alsa-project.org, Takashi Iwai References: <20230504130007.2208916-1-oswald.buddenhagen@gmx.de> <266661e5-ac86-1590-55d9-5f14e6486557@perex.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <266661e5-ac86-1590-55d9-5f14e6486557@perex.cz> Message-ID-Hash: 5H37CUZOGH2IAWUWVOR2U7KQJEV22QTJ X-Message-ID-Hash: 5H37CUZOGH2IAWUWVOR2U7KQJEV22QTJ X-MailFrom: ossi@kde.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, Takashi Iwai X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, May 04, 2023 at 03:08:14PM +0200, Jaroslav Kysela wrote: >On 04. 05. 23 15:00, Oswald Buddenhagen wrote: >> So we logically revert some bits from commit 9f656705c5faa ("ALSA: >> pcm: >> rewrite snd_pcm_playback_silence()"), but we retain the bug fixes and >> try to make the code paths congruent. > >It would be better to revert the broken patch and make changes on top of the >original code. This is really difficult to review. > the diff to the old code is just as big, which is a somewhat inevitable effect of it being the middle way between both. the best way to review it is with `git show -b`. regards