From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-block@nongnu.org, stefanha@redhat.com, eesposit@redhat.com,
pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 12/20] mirror: Require GRAPH_RDLOCK for accessing a node's parent list
Date: Thu, 4 May 2023 17:17:33 +0200 [thread overview]
Message-ID: <ZFPMjfTz478ZuJGE@redhat.com> (raw)
In-Reply-To: <vvrehglysx4vfeuusciyfamfshz54u3dqhqb3cnenjzalysiqi@ekx46ms77hv7>
Am 04.05.2023 um 15:17 hat Eric Blake geschrieben:
> On Thu, May 04, 2023 at 01:57:42PM +0200, Kevin Wolf wrote:
> > This adds GRAPH_RDLOCK annotations to declare that functions accessing
> > the parent list of a node need to hold a reader lock for the graph. As
> > it happens, they already do.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > ---
> > block/mirror.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Oops, sorry for failing to pick up your R-b for this patch in v1 (seems
I only changed the subject line and forgot about the reviews), and
thanks for renewing it. :-)
Kevin
next prev parent reply other threads:[~2023-05-04 17:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 11:57 [PATCH v2 00/20] Graph locking, part 3 (more block drivers) Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 01/20] qcow2: Don't call bdrv_getlength() in coroutine_fns Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 02/20] block: Consistently call bdrv_activate() outside coroutine Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 03/20] block: bdrv/blk_co_unref() for calls in coroutine context Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 04/20] block: Don't call no_coroutine_fns in qmp_block_resize() Kevin Wolf
2023-05-05 12:02 ` Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 05/20] test-bdrv-drain: Don't modify the graph in coroutines Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 06/20] graph-lock: Add GRAPH_UNLOCKED(_PTR) Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 07/20] graph-lock: Fix GRAPH_RDLOCK_GUARD*() to be reader lock Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 08/20] block: .bdrv_open is non-coroutine and unlocked Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 09/20] nbd: Remove nbd_co_flush() wrapper function Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 10/20] nbd: Mark nbd_co_do_establish_connection() and callers GRAPH_RDLOCK Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 11/20] vhdx: Require GRAPH_RDLOCK for accessing a node's parent list Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 12/20] mirror: " Kevin Wolf
2023-05-04 13:17 ` Eric Blake
2023-05-04 15:17 ` Kevin Wolf [this message]
2023-05-04 11:57 ` [PATCH v2 13/20] block: Mark bdrv_co_get_allocated_file_size() and callers GRAPH_RDLOCK Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 14/20] block: Mark bdrv_co_get_info() " Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 15/20] block: Mark bdrv_co_debug_event() GRAPH_RDLOCK Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 16/20] block: Mark BlockDriver callbacks for amend job GRAPH_RDLOCK Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 17/20] block: Mark bdrv_query_bds_stats() and callers GRAPH_RDLOCK Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 18/20] block: Mark bdrv_query_block_graph_info() " Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 19/20] block: Mark bdrv_recurse_can_replace() " Kevin Wolf
2023-05-04 11:57 ` [PATCH v2 20/20] block: Mark bdrv_refresh_limits() " Kevin Wolf
2023-05-09 17:07 ` [PATCH v2 00/20] Graph locking, part 3 (more block drivers) Kevin Wolf
2023-05-09 17:48 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFPMjfTz478ZuJGE@redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=eesposit@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.