Re: [PATCH 1/2] migration: Document all migration_stats

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, May 04, 2023 at 12:33:56PM +0200, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/migration-stats.h | 43 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/migration/migration-stats.h b/migration/migration-stats.h
> index 149af932d7..0e49c236fa 100644
> --- a/migration/migration-stats.h
> +++ b/migration/migration-stats.h
> @@ -22,17 +22,60 @@
>   * one thread).
>   */
>  typedef struct {
> +    /*
> +     * number of bytes that were dirty last time that we sync with the

 s/sync/synced/

> +     * guest memory.  We use that to calculate the downtime.  As the
> +     * remaining dirty amounts to what we know that is still dirty
> +     * since last iteration, not counting what the guest has dirtied
> +     * sync we synchronize bitmaps.

  s/synchronize/synchronized/

> +     */
>      Stat64 dirty_bytes_last_sync;
> +    /*
> +     * number of pages dirtied by second.

 s/by/per/

> +     */
>      Stat64 dirty_pages_rate;
> +    /*
> +     * number of times we have synchronize guest bitmaps.

  s/synchronize/synchronized/

>      Stat64 postcopy_bytes;
> +    /*
> +     * number of postcopy page faults that we have handled during
> +     * postocpy stage.

s/postocpy/postcopy/


Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|