From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51576C77B7C for ; Thu, 4 May 2023 21:45:27 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.530185.825613 (Exim 4.92) (envelope-from ) id 1pugl5-00069V-4z; Thu, 04 May 2023 21:45:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 530185.825613; Thu, 04 May 2023 21:45:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugl5-00069O-1V; Thu, 04 May 2023 21:45:03 +0000 Received: by outflank-mailman (input) for mailman id 530185; Thu, 04 May 2023 21:45:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pugl4-00069I-2s for xen-devel@lists.xenproject.org; Thu, 04 May 2023 21:45:02 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eab4ca4d-eac4-11ed-8611-37d641c3527e; Thu, 04 May 2023 23:45:00 +0200 (CEST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-HnOtJYstOJWrNZLz1UfM9w-1; Thu, 04 May 2023 17:44:54 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 994CD85531A; Thu, 4 May 2023 21:44:53 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6800363F3E; Thu, 4 May 2023 21:44:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eab4ca4d-eac4-11ed-8611-37d641c3527e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683236698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4uQyhS4chih7E8Y8+j3wgbWTkP0aNND6XQO9VSCZB+8=; b=QqzhyulZJcSxtO71aQremSieAmDQzt4gL7EOMpT5iWsE0lOr57a7WtYA48cWkyVl6+ole/ wcxoRjau6hBoubpbUEuPksBmzeyFe82LaFjoVMzpC+SSGc/PH5ceIIg2FXiCgBskq9Ki3p +JsJXhTSz3yEFRUftZpEuW6/StVUZsY= X-MC-Unique: HnOtJYstOJWrNZLz1UfM9w-1 Date: Thu, 4 May 2023 23:44:42 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Ronnie Sahlberg , Aarushi Mehta , qemu-block@nongnu.org, Paul Durrant , Anthony Perard , Peter Lieven , Stefan Weil , Xie Yongji , Paolo Bonzini , "Michael S. Tsirkin" , Leonardo Bras , Peter Xu , Hanna Reitz , Stefano Stabellini , Richard Henderson , David Woodhouse , Coiby Xu , Eduardo Habkost , Stefano Garzarella , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Julia Suvorova , xen-devel@lists.xenproject.org, eesposit@redhat.com, Juan Quintela , "Richard W.M. Jones" , Fam Zheng , Marcel Apfelbaum Subject: Re: [PATCH v5 00/21] block: remove aio_disable_external() API Message-ID: References: <20230504195327.695107-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230504195327.695107-1-stefanha@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Am 04.05.2023 um 21:53 hat Stefan Hajnoczi geschrieben: > v5: > - Use atomic accesses for in_flight counter in vhost-user-server.c [Kevin] > - Stash SCSIDevice id/lun values for VIRTIO_SCSI_T_TRANSPORT_RESET event > before unrealizing the SCSIDevice [Kevin] > - Keep vhost-user-blk export .detach() callback so ctx is set to NULL [Kevin] > - Narrow BdrvChildClass and BlockDriver drained_{begin/end/poll} callbacks from > IO_OR_GS_CODE() to GLOBAL_STATE_CODE() [Kevin] > - Include Kevin's "block: Fix use after free in blockdev_mark_auto_del()" to > fix a latent bug that was exposed by this series I only just finished reviewing v4 when you had already sent v5, but it hadn't arrived yet. I had a few more comments on what are now patches 17, 18, 19 and 21 in v5. I think they all still apply. Kevin