All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Wang Honghui <honghui.wang@ucas.com.cn>,
	Oliver Neukum <oliver@neukum.org>, Ali Akcaagac <aliakc@web.de>,
	Jamie Lenehan <lenehan@twibble.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	dc395x@twibble.org, linux-scsi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi:dc395x: Correct "structures" spelling mistakes
Date: Fri, 5 May 2023 14:42:19 +0700	[thread overview]
Message-ID: <ZFSzW2sFnyXGcJcL@debian.me> (raw)
In-Reply-To: <9721BDA46BD84475+ZFTPVLLFKTMn4lSE@TP-P15V>

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

On Fri, May 05, 2023 at 05:41:40PM +0800, Wang Honghui wrote:
> Signed-off-by: Wang Honghui <honghui.wang@ucas.com.cn>
> 
> As title.

1) This is v2 of [1], right? Did you forget to pass `-v` to
   git-format-patch(1)?
2) The trailers (including SoB) should be placed after the patch description.
3) Last but not least, you forget to add my Reviewed-by: from v1 [1].

Please reroll, keeping above in mind.

Thanks.

[1]: https://lore.kernel.org/all/262EBDA8BEEA7619+ZFN1b1D66%2FLp8hzh@TP-P15V/
[2]: https://lore.kernel.org/all/ZFOD%2F6rT36evHXNz@debian.me/

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2023-05-05  7:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05  9:41 [PATCH] scsi:dc395x: Correct "structures" spelling mistakes Wang Honghui
2023-05-05  7:42 ` Bagas Sanjaya [this message]
2023-05-05  7:50 ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFSzW2sFnyXGcJcL@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=aliakc@web.de \
    --cc=dc395x@twibble.org \
    --cc=honghui.wang@ucas.com.cn \
    --cc=jejb@linux.ibm.com \
    --cc=lenehan@twibble.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.