From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDCF1C77B75 for ; Fri, 5 May 2023 10:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231308AbjEEKlt (ORCPT ); Fri, 5 May 2023 06:41:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231225AbjEEKls (ORCPT ); Fri, 5 May 2023 06:41:48 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE9D31155A for ; Fri, 5 May 2023 03:41:46 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 914112216F; Fri, 5 May 2023 10:41:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1683283305; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yv5avKygEKTSSLv3g87KeqR+dkSWiqbpFDaM6k01oVU=; b=fGQdMOAVofQeamXwqjA2YXKc93EAWTFarli3pylk3yMl0Cfrj4Xpri3f3cR0nznp22GZnA 4sCpBUBzNZ6zZAtHhnVIW8dfdBpSB0xWCOgDp9qZgroO3/m6fkeTrIiwJJVQCtBpnzq/Ea EL0Lja2xJGBZ8RWbUwkBq7EblyQ8oMo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1683283305; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yv5avKygEKTSSLv3g87KeqR+dkSWiqbpFDaM6k01oVU=; b=Y/GmTwvbMaZ7AfzTZ1tWXqKTqL/L/RbrWWJQ7lfXc3J5O9/f3GnbhnATcCX1X5frq5B4DM TLD0i3+PZw1yQ1Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 79BD613513; Fri, 5 May 2023 10:41:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8S7+HGndVGTKfwAAMHmgww (envelope-from ); Fri, 05 May 2023 10:41:45 +0000 Date: Fri, 5 May 2023 12:42:47 +0200 From: Cyril Hrubis To: Petr Vorel Cc: ltp@lists.linux.it, NeilBrown , linux-nfs@vger.kernel.org, Jeff Layton Subject: Re: [PATCH v5 1/5] nfs_lib.sh: Cleanup local and remote directories setup Message-ID: References: <20230504131414.3826283-1-pvorel@suse.cz> <20230504131414.3826283-2-pvorel@suse.cz> <20230504211634.GA4244@pevik> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230504211634.GA4244@pevik> Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi! > > It's a bit puzzling why we have two identical functions with a different > > name... > > It's a preparation for TST_ALL_FILESYSTEMS=1 where the location changes. > I can squash this into that commit where it changes. That is the missing bit. No need to squash maybe just note that the directory will change in the last commit of the patchset. -- Cyril Hrubis chrubis@suse.cz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E95EC77B7C for ; Fri, 5 May 2023 10:41:59 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 512893CB6EA for ; Fri, 5 May 2023 12:41:57 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 6ED293CB671 for ; Fri, 5 May 2023 12:41:47 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id E61216019AB for ; Fri, 5 May 2023 12:41:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 914112216F; Fri, 5 May 2023 10:41:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1683283305; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yv5avKygEKTSSLv3g87KeqR+dkSWiqbpFDaM6k01oVU=; b=fGQdMOAVofQeamXwqjA2YXKc93EAWTFarli3pylk3yMl0Cfrj4Xpri3f3cR0nznp22GZnA 4sCpBUBzNZ6zZAtHhnVIW8dfdBpSB0xWCOgDp9qZgroO3/m6fkeTrIiwJJVQCtBpnzq/Ea EL0Lja2xJGBZ8RWbUwkBq7EblyQ8oMo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1683283305; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yv5avKygEKTSSLv3g87KeqR+dkSWiqbpFDaM6k01oVU=; b=Y/GmTwvbMaZ7AfzTZ1tWXqKTqL/L/RbrWWJQ7lfXc3J5O9/f3GnbhnATcCX1X5frq5B4DM TLD0i3+PZw1yQ1Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 79BD613513; Fri, 5 May 2023 10:41:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8S7+HGndVGTKfwAAMHmgww (envelope-from ); Fri, 05 May 2023 10:41:45 +0000 Date: Fri, 5 May 2023 12:42:47 +0200 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20230504131414.3826283-1-pvorel@suse.cz> <20230504131414.3826283-2-pvorel@suse.cz> <20230504211634.GA4244@pevik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230504211634.GA4244@pevik> X-Virus-Scanned: clamav-milter 0.102.4 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v5 1/5] nfs_lib.sh: Cleanup local and remote directories setup X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: NeilBrown , linux-nfs@vger.kernel.org, Jeff Layton , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > It's a bit puzzling why we have two identical functions with a different > > name... > > It's a preparation for TST_ALL_FILESYSTEMS=1 where the location changes. > I can squash this into that commit where it changes. That is the missing bit. No need to squash maybe just note that the directory will change in the last commit of the patchset. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp