From: Simon Horman <horms@kernel.org>
To: Pingfan Liu <piliu@redhat.com>
Cc: kexec@lists.infradead.org, ardb@kernel.org, jeremy.linton@arm.com
Subject: Re: [PATCH 1/5] kexec: Adding missing free for kernel_buf
Date: Fri, 5 May 2023 17:32:18 +0200 [thread overview]
Message-ID: <ZFUhgnfTwJEKIBpp@kernel.org> (raw)
In-Reply-To: <20230505025438.11943-2-piliu@redhat.com>
On Fri, May 05, 2023 at 10:54:33AM +0800, Pingfan Liu wrote:
> slurp_decompress_file() allocates memory but nowhere to free it.
> Adding that missing free.
Hi Pingfan,
There seem to be:
a) other places where slurp_decompress_file() is called and;
b) other places where do_kexec_file_load() returns.
I wonder if a more comprehensive fix appropriate.
>
> Signed-off-by: Pingfan Liu <piliu@redhat.com>
> To: kexec@lists.infradead.org
> Cc: horms@verge.net.au
> Cc: ardb@kernel.org
> Cc: jeremy.linton@arm.com
> ---
> kexec/kexec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kexec/kexec.c b/kexec/kexec.c
> index 36bb2ad..614cd1d 100644
> --- a/kexec/kexec.c
> +++ b/kexec/kexec.c
> @@ -1379,6 +1379,7 @@ static int do_kexec_file_load(int fileind, int argc, char **argv,
> }
> }
>
> + free(kernel_buf);
> close(kernel_fd);
> return ret;
> }
> --
> 2.31.1
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2023-05-05 15:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 2:54 [PATCH 0/5] arm64: zboot support Pingfan Liu
2023-05-05 2:54 ` [PATCH 1/5] kexec: Adding missing free for kernel_buf Pingfan Liu
2023-05-05 15:32 ` Simon Horman [this message]
2023-05-05 2:54 ` [PATCH 2/5] arm64/zImage: Remove unnecessary allocation for kernel_uncompressed_buf Pingfan Liu
2023-05-05 2:54 ` [PATCH 3/5] arm64: change the prototype of image probe function Pingfan Liu
2023-05-05 15:42 ` Simon Horman
2023-05-06 3:14 ` Pingfan Liu
2023-05-05 2:54 ` [PATCH 4/5] arm64: Scatter the logic of reading of kernel file into each probe Pingfan Liu
2023-05-05 2:54 ` [PATCH 4/5] arm64: Scatter the " Pingfan Liu
2023-05-05 22:38 ` [PATCH 0/5] arm64: zboot support Jeremy Linton
2023-05-06 3:12 ` Pingfan Liu
2023-05-06 3:05 ` [PATCH 5/5] arm64: add support for zboot image Pingfan Liu
2023-05-12 3:10 ` [PATCH 0/5] arm64: zboot support Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFUhgnfTwJEKIBpp@kernel.org \
--to=horms@kernel.org \
--cc=ardb@kernel.org \
--cc=jeremy.linton@arm.com \
--cc=kexec@lists.infradead.org \
--cc=piliu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.