From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-renesas-soc@vger.kernel.org,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 1/3] dt-bindings: PCI: rcar-pci-host: add optional regulators
Date: Mon, 8 May 2023 20:48:15 +0200 [thread overview]
Message-ID: <ZFlD7x99++k3yfE1@kunai> (raw)
In-Reply-To: <CAMuHMdWGaDT_XGpeVm-915hbxa8-w5303QWg0a0iCjqk998unQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 892 bytes --]
Hi Geert,
> > + vpcie1v5-supply:
> > + description: The 1.5v regulator to use for PCIe.
>
> +1.5V is only present on mini-PCIe slots...
Since mini-PCIe is a subset of PCIe, I'd think we can leave the
description as-is.
> > +
> > + vpcie3v3-supply:
> > + description: The 3.3v regulator to use for PCIe.
>
> ... while +3.3V is present on PCIe, mini-PCIe, and M2 PCIe slots.
>
> In addition, normal PCIe slots also have +12V.
> So I think it would be prudent to add a vpcie12v0-supply property, too.
I agree. I can't test it but it is trivial enough to add 12v support as
well.
> W.r.t. to the actual naming, I don't know if there's already a (de facto)
> standard for that?
I couldn't find one and took what I think is the most used pattern. But
I wasn't entirely sure, this is why the series is still RFC.
Thanks for the review!
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-05-08 18:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 10:45 [RFC PATCH 0/3] KingFisher: support regulators for PCIe Wolfram Sang
2023-05-08 10:45 ` [RFC PATCH 1/3] dt-bindings: PCI: rcar-pci-host: add optional regulators Wolfram Sang
2023-05-08 11:27 ` Rob Herring
2023-05-08 13:40 ` Geert Uytterhoeven
2023-05-08 18:48 ` Wolfram Sang [this message]
2023-05-09 10:35 ` Geert Uytterhoeven
2023-05-09 12:30 ` Wolfram Sang
2023-05-08 10:45 ` [RFC PATCH 2/3] PCI: rcar-host: add support for " Wolfram Sang
2023-05-08 13:45 ` Geert Uytterhoeven
2023-05-09 10:20 ` Wolfram Sang
2023-05-08 10:45 ` [RFC PATCH 3/3] arm64: dts: renesas: ulcb-kf: add regulators for PCIe ch1 Wolfram Sang
2023-05-08 13:46 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFlD7x99++k3yfE1@kunai \
--to=wsa+renesas@sang-engineering.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.