All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Udipto Goswami <quic_ugoswami@quicinc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Pratham Pratap <quic_ppratap@quicinc.com>,
	Jack Pham <quic_jackp@quicinc.com>,
	Johan Hovold <johan+linaro@kernel.org>,
	Oliver Neukum <oneukum@suse.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v9] usb: dwc3: debugfs: Prevent any register access when devices is runtime suspended
Date: Tue, 9 May 2023 08:30:10 +0200	[thread overview]
Message-ID: <ZFnoctKuC2i2T8qV@hovoldconsulting.com> (raw)
In-Reply-To: <34a33b09-20aa-13e3-e4bd-c8b5854450a4@quicinc.com>

On Mon, May 08, 2023 at 09:18:17PM +0530, Udipto Goswami wrote:

> > I believe this should be backported as it fixes a crash/hang.
> > 
> > The stable rules are flexible, but it may also be possible to break the
> > patch up in pieces and add a corresponding Fixes tag.
> 
> Agree, I will add a fixes tag for the oldest change that introduced the 
> debugfs attributes instead of breaking it to multiple patches and adding 
> fixes for each one. (I think the present code changes can stay in one 
> patch as we are fixing the same issue in all the functions).
> 
> Let me know if you think otherwise?

Sounds good to me. Note that the fix depends on 

	30332eeefec8 ("debugfs: regset32: Add Runtime PM support")

which went into 5.7.

This can be documented as

	Cc: stable@vger.kernel.org	# 3.2: 30332eeefec8: debugfs: regset32: Add Runtime PM support

(see Documentation/process/stable-kernel-rules.rst).

Note that this issue appears to have been there since the driver was
first merged in 3.2.

Johan

  reply	other threads:[~2023-05-09  6:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-05 15:51 [PATCH v9] usb: dwc3: debugfs: Prevent any register access when devices is runtime suspended Udipto Goswami
2023-05-06  1:30 ` Thinh Nguyen
2023-05-08 11:34   ` Johan Hovold
2023-05-08 15:48     ` Udipto Goswami
2023-05-09  6:30       ` Johan Hovold [this message]
2023-05-08 22:26     ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFnoctKuC2i2T8qV@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=johan+linaro@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=quic_jackp@quicinc.com \
    --cc=quic_ppratap@quicinc.com \
    --cc=quic_ugoswami@quicinc.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.