From: "Theodore Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>,
syzbot+e2efa3efc15a1c9e95c3@syzkaller.appspotmail.com
Subject: Re: [PATCH 1/2] ext4: allow ext4_get_group_info() to fail
Date: Tue, 9 May 2023 20:22:11 -0400 [thread overview]
Message-ID: <ZFrjs2i9xK+ektHd@mit.edu> (raw)
In-Reply-To: <20230507181816.tsnqhzgajftcbsz5@quack3>
On Sun, May 07, 2023 at 08:18:16PM +0200, Jan Kara wrote:
> The patch looks good except for one small problem already found by Julia:
>
> > @@ -2578,7 +2595,7 @@ void ext4_mb_prefetch_fini(struct super_block *sb, ext4_group_t group,
> > gdp = ext4_get_group_desc(sb, group, NULL);
> > grp = ext4_get_group_info(sb, group);
> >
> > - if (EXT4_MB_GRP_NEED_INIT(grp) &&
> > + if (grp && grp && EXT4_MB_GRP_NEED_INIT(grp) &&
> ^^^ one of these should be gdp.
>
> With this fixed feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Thanks for the review, fixed in my tree.
- Ted
next prev parent reply other threads:[~2023-05-10 0:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-30 15:43 [PATCH 0/2] ext4: fix syzbot report: kernel BUG in ext4_get_group_info Theodore Ts'o
2023-04-30 15:43 ` [PATCH 1/2] ext4: allow ext4_get_group_info() to fail Theodore Ts'o
2023-05-07 18:18 ` Jan Kara
2023-05-10 0:22 ` Theodore Ts'o [this message]
2023-04-30 15:43 ` [PATCH 2/2] ext4: remove a BUG_ON in ext4_mb_release_group_pa() Theodore Ts'o
2023-05-07 18:28 ` Jan Kara
2023-05-08 20:35 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFrjs2i9xK+ektHd@mit.edu \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=syzbot+e2efa3efc15a1c9e95c3@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.