All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, hreitz@redhat.com,
	den@openvz.org, alexander.ivanov@virtuozzo.com
Subject: Re: [PATCH v8 2/5] blockdev: transactions: rename some things
Date: Wed, 10 May 2023 13:16:04 +0200	[thread overview]
Message-ID: <ZFt89PEmN7GWc1di@redhat.com> (raw)
In-Reply-To: <20230421115327.907104-3-vsementsov@yandex-team.ru>

Am 21.04.2023 um 13:53 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Look at qmp_transaction(): dev_list is not obvious name for list of
> actions. Let's look at qapi spec, this argument is "actions". Let's
> follow the common practice of using same argument names in qapi scheme
> and code.
> 
> To be honest, rename props to properties for same reason.
> 
> Next, we have to rename global map of actions, to not conflict with new
> name for function argument.
> 
> Rename also dev_entry loop variable accordingly to new name of the
> list.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

Reviewed-by: Kevin Wolf <kwolf@redhat.com>



  reply	other threads:[~2023-05-10 11:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 11:53 [PATCH v8 0/5] block: refactor blockdev transactions Vladimir Sementsov-Ogievskiy
2023-04-21 11:53 ` [PATCH v8 1/5] blockdev: refactor transaction to use Transaction API Vladimir Sementsov-Ogievskiy
2023-05-10 11:10   ` Kevin Wolf
2023-04-21 11:53 ` [PATCH v8 2/5] blockdev: transactions: rename some things Vladimir Sementsov-Ogievskiy
2023-05-10 11:16   ` Kevin Wolf [this message]
2023-04-21 11:53 ` [PATCH v8 3/5] blockdev: qmp_transaction: refactor loop to classic for Vladimir Sementsov-Ogievskiy
2023-05-10 11:17   ` Kevin Wolf
2023-04-21 11:53 ` [PATCH v8 4/5] blockdev: transaction: refactor handling transaction properties Vladimir Sementsov-Ogievskiy
2023-05-10 11:21   ` Kevin Wolf
2023-04-21 11:53 ` [PATCH v8 5/5] blockdev: qmp_transaction: drop extra generic layer Vladimir Sementsov-Ogievskiy
2023-05-10 11:47   ` Kevin Wolf
2023-05-10 13:37     ` Vladimir Sementsov-Ogievskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFt89PEmN7GWc1di@redhat.com \
    --to=kwolf@redhat.com \
    --cc=alexander.ivanov@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=hreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.