From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A045C7EE2D for ; Wed, 10 May 2023 09:12:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwfrL-0003ly-Ot; Wed, 10 May 2023 05:11:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwfrF-0003dt-6O for qemu-devel@nongnu.org; Wed, 10 May 2023 05:11:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwfrD-0000oC-3c for qemu-devel@nongnu.org; Wed, 10 May 2023 05:11:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683709893; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vCim6mvWRhbyIuFf4jt39b+gOOX9D4pXu7jPwuhag/A=; b=gLNKU2TxgJfzq1jx/QjmMyAEq56YcofsdO+ELk4X5M3IA2qgG+IvB45GHxo91gmyyP6PcJ +WHczA1pY7zKjUGabvaHPUoYqviNQ+JIo1oMggivUiZ1JzrxAC0T/W61IhLjzszxb4nxWl M1w7jbFu3ilinzBE/V/Ot1lScboawko= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-498-oGztCokWPVWfdSKro4wOzA-1; Wed, 10 May 2023 05:11:30 -0400 X-MC-Unique: oGztCokWPVWfdSKro4wOzA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 25D928037A8; Wed, 10 May 2023 09:11:30 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E6E704078906; Wed, 10 May 2023 09:11:27 +0000 (UTC) Date: Wed, 10 May 2023 10:11:24 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Ani Sinha Cc: Alex =?utf-8?Q?Benn=C3=A9e?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal , qemu-devel@nongnu.org Subject: Re: [PATCH] docs/devel: remind developers to run CI container pipeline when updating images Message-ID: References: <20230506072012.10350-1-anisinha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230506072012.10350-1-anisinha@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sat, May 06, 2023 at 12:50:12PM +0530, Ani Sinha wrote: > When new dependencies and packages are added to containers, its important to > run CI container generation pipelines on gitlab to make sure that there are no > obvious conflicts between packages that are being added and those that are > already present. Running CI container pipelines will make sure that there are > no such breakages before we commit the change updating the containers. Add a > line in the documentation reminding developers to run the pipeline before > submitting the change. It will also ease the life of the maintainers. > > Signed-off-by: Ani Sinha > --- > docs/devel/testing.rst | 6 ++++++ > 1 file changed, 6 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|