From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Yafang Shao <laoar.shao@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: pahole issue. Re: [PATCH bpf-next 2/2] fork: Rename mm_init to task_mm_init
Date: Wed, 10 May 2023 12:28:17 -0300 [thread overview]
Message-ID: <ZFu4Ea/zBPAFYwcH@kernel.org> (raw)
In-Reply-To: <5ef0ff27-2720-42c0-d432-c21ecde0c58d@oracle.com>
Em Wed, May 10, 2023 at 02:08:49PM +0100, Alan Maguire escreveu:
> On 09/05/2023 22:21, Alexei Starovoitov wrote:
> > On Tue, May 9, 2023 at 11:44 AM Alan Maguire <alan.maguire@oracle.com> wrote:
> >> On 02/05/2023 04:40, Alexei Starovoitov wrote:
> >> won't the pahole v1.25 changes help here; can you try applying
> >> https://lore.kernel.org/bpf/1675949331-27935-1-git-send-email-alan.maguire@oracle.com/
> >> ...and build using pahole; this should eliminate any functions
> >> with inconsistent prototypes via
> >> --skip_encoding_btf_inconsistent_proto
> >> Do not encode functions with multiple inconsistent prototypes or
> >> unexpected register use for their parameters, where the regis‐
> >> ters used do not match calling conventions.
> >> I'll check this at my end too.
> >> Alexei, if this works should we look at applying the above
> >> again to bpf-next? If so I'll resend the patch.
> > I've lost the track with pahole fixes.
> > Did Arnaldo re-tag pahole 1.25 or released 1.26 with the fixes?
> My understanding is the pahole repo is prepped for v1.25,
> meaning that it will build with version 1.25 but it is
> not officially released yet; Arnaldo will correct me if
> I've got that wrong.
Right, pahole 1.25 was released with those options/fixes.
- Arnaldo
> > Alan,
> > please submit a fresh patch for bpf-next to enable
> > --skip_encoding_btf_inconsistent_proto, so it can go through CI.
> > I cannot test all combinations manually.
> >
>
> Done; see [1]. If CI picks up the latest version from
> the dwarves repo, it will see version 1.25.
>
> I've tested the above specific case along with general testing
> using latest pahole.
>
> When running pahole with --verbose and
> --skip_encoding_btf_inconsistent_proto
>
> we see:
>
> skipping addition of 'mm_init'(mm_init) due to multiple inconsistent
> function prototypes
>
>
> ...and
>
> bpftool btf dump file vmlinux |grep mm_init
>
> shows the function is not encoded in BTF due to these inconsistencies.
>
> Thanks!
>
> Alan
>
> [1]
> https://lore.kernel.org/bpf/20230510130241.1696561-1-alan.maguire@oracle.com/
next prev parent reply other threads:[~2023-05-10 15:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 16:11 [PATCH bpf-next 0/2] bpf: Fix issues caused by bpf trampoline Yafang Shao
2023-04-24 16:11 ` [PATCH bpf-next 1/2] bpf: Add __rcu_read_{lock,unlock} into btf id deny list Yafang Shao
2023-04-24 16:11 ` [PATCH bpf-next 2/2] fork: Rename mm_init to task_mm_init Yafang Shao
2023-04-24 21:13 ` Alexei Starovoitov
2023-04-27 11:34 ` Yafang Shao
2023-05-02 3:40 ` pahole issue. " Alexei Starovoitov
2023-05-09 15:35 ` Yafang Shao
2023-05-09 17:18 ` Alexei Starovoitov
2023-05-10 5:38 ` Yafang Shao
2023-05-10 13:54 ` Yonghong Song
2023-05-09 18:43 ` Alan Maguire
2023-05-09 21:21 ` Alexei Starovoitov
2023-05-10 13:08 ` Alan Maguire
2023-05-10 15:28 ` Arnaldo Carvalho de Melo [this message]
2023-04-24 21:30 ` [PATCH bpf-next 0/2] bpf: Fix issues caused by bpf trampoline patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFu4Ea/zBPAFYwcH@kernel.org \
--to=acme@kernel.org \
--cc=alan.maguire@oracle.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.