From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A3B2C77B7D for ; Wed, 10 May 2023 11:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236673AbjEJLsI (ORCPT ); Wed, 10 May 2023 07:48:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231875AbjEJLsH (ORCPT ); Wed, 10 May 2023 07:48:07 -0400 Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E783E30EF for ; Wed, 10 May 2023 04:48:05 -0700 (PDT) Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2) (envelope-from ) id 1pwiIb-0001gx-Q8; Wed, 10 May 2023 13:48:01 +0200 Date: Wed, 10 May 2023 13:48:01 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: Florian Westphal , netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH] evaluate: Reject set stmt refs to sets without dynamic flag Message-ID: Mail-Followup-To: Phil Sutter , Pablo Neira Ayuso , Florian Westphal , netfilter-devel@vger.kernel.org References: <20230503105022.5728-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi Pablo, On Wed, May 10, 2023 at 12:54:28PM +0200, Pablo Neira Ayuso wrote: > On Wed, May 03, 2023 at 12:50:22PM +0200, Phil Sutter wrote: > > This is a revert of commit 8d443adfcc8c1 ("evaluate: attempt to set_eval > > flag if dynamic updates requested"), implementing the alternative > > mentioned in the comment it added. > > > > Reason is the inconsistent behaviour when applying the same ruleset > > twice: In the first call, the set lacking 'dynamic' flag does not exist > > and is therefore added to the cache. Consequently, both the 'add set' > > command and the set statement point at the same set object. In the > > second call, a set with same name exists already, so the object created > > for 'add set' command is not added to cache and consequently not updated > > with the missing flag. The kernel thus rejects the NEWSET request as the > > existing set differs from the new one. > > # cat test.nft > flush ruleset Just remove this 'flush ruleset' call, then it should trigger. Cheers, Phil