All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v3] ALSA: pcm: auto-fill buffer with silence when draining playback
Date: Wed, 10 May 2023 19:12:20 +0200	[thread overview]
Message-ID: <ZFvQdJ2/d1muNQPO@ugly> (raw)
In-Reply-To: <24e60af6-9585-289c-05e5-5b34370c6dba@perex.cz>

On Wed, May 10, 2023 at 06:54:57PM +0200, Jaroslav Kysela wrote:
>NAK. Already implemented in alsa-lib which is enough for the first 
>implementation.
>
did you read the part below the cut-off line? ;-)

>> you are NOT expected to apply this. i just needed it for my testing
>> (it's easier to deploy as i'm hacking on the kernel anyway) and wanted
>> to post it for posterity.

this patch should serve as a template for fixing the bug in the 
user-space implementation i reported a few days back. i'll post a patch 
sometimes soon if you don't beat me to it.

also, i think the drain_silence config should be re-interpreted as 
overriding the default 1/10th sec "overshoot", rather than nonsensically 
the total delay irrespective of period size.

regards

      reply	other threads:[~2023-05-10 17:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10 16:29 [PATCH v3] ALSA: pcm: auto-fill buffer with silence when draining playback Oswald Buddenhagen
2023-05-10 16:54 ` Jaroslav Kysela
2023-05-10 17:12   ` Oswald Buddenhagen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFvQdJ2/d1muNQPO@ugly \
    --to=oswald.buddenhagen@gmx.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.