From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1C4D3D60; Wed, 10 May 2023 17:34:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C2FDC433D2; Wed, 10 May 2023 17:34:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683740097; bh=NnMa4/6VIx6yW41nazHwwitKXnWorurym5zBq4Ka0XY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jRo3jRZJDb/ziEHcYjG6t77yGeolVrZqQA3zUzLWSQFI7MZweGu4GL/g4VnbdIO0L 6e5lWTdD5ZPwxQ3FmWKtybySqvbfZdQyjsym1DpQsJGipspkcj9okAp7BL5ywvn0mB PFDTljAY+P1LmVcJW+pIreogI63jKwLk+AJUoj5AC9oXquwoiD1kILywh6qlhB0Dcn juPH3sTfFIQcHwG9Qs4M43g4df6VTtHIjGVSGvo+qxkAtjxgZhiKQZNlz2okv+Pjys 3gW0GaHsLlibWtUnkgO6pTrHA9YrBX6v8DABsgrX/5AUVg1Ge/yQEaXELP8phjOmZE PLkc0LXe3/zQg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BE0DD403B5; Wed, 10 May 2023 14:34:54 -0300 (-03) Date: Wed, 10 May 2023 14:34:54 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Song Liu , Yang Jihong , Andrii Nakryiko , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v1] perf build: Add system include paths to BPF builds Message-ID: References: <20230506021450.3499232-1-irogers@google.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230506021450.3499232-1-irogers@google.com> X-Url: http://acmel.wordpress.com Em Fri, May 05, 2023 at 07:14:50PM -0700, Ian Rogers escreveu: > There are insufficient headers in tools/include to satisfy building > BPF programs and their header dependencies. Add the system include > paths from the non-BPF clang compile so that these headers can be > found. > > This code was taken from: > tools/testing/selftests/bpf/Makefile > > Signed-off-by: Ian Rogers > --- > tools/perf/Makefile.perf | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 61c33d100b2b..37befdfa8ac8 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -1057,7 +1057,25 @@ $(SKEL_TMP_OUT) $(LIBAPI_OUTPUT) $(LIBBPF_OUTPUT) $(LIBPERF_OUTPUT) $(LIBSUBCMD_ > > ifndef NO_BPF_SKEL So this patch was done before the reverts, I adjusted it to what is upstream and to another patch that makes the build use the headers from the perf sources instead of the system's (linux/bpf.h and linux/perf_event.h, from vmlinux.h), please take a look at the patch below, I'm also trying to figure out that other problem you pointed with linux/types.s :-\ What I have now in tmp.perf-tools: ⬢[acme@toolbox perf-tools]$ git log --oneline torvalds/master.. a2af0f6b8ef7ea40 (HEAD -> perf-tools) perf build: Add system include paths to BPF builds 5be6cecda0802f23 perf bpf skels: Make vmlinux.h use bpf.h and perf_event.h in source directory 7d161165d9072dcb perf parse-events: Do not break up AUX event group a468085011ea8bba perf test test_intel_pt.sh: Test sample mode with event with PMU name 123361659fa405de perf evsel: Modify group pmu name for software events 34e82891d995ab89 tools arch x86: Sync the msr-index.h copy with the kernel sources 705049ca4f5b7b00 tools headers kvm: Sync uapi/{asm/linux} kvm.h headers with the kernel sources 8d6a41c8065e1120 tools include UAPI: Sync the sound/asound.h copy with the kernel sources 92b8e61e88351091 tools headers UAPI: Sync the linux/const.h with the kernel headers e7ec3a249c38a9c9 tools headers UAPI: Sync the i915_drm.h with the kernel sources e6232180e524e112 tools headers UAPI: Sync the drm/drm.h with the kernel sources 5d1ac59ff7445e51 tools headers UAPI: Sync the linux/in.h with the kernel sources b0618f38e2ab8ce3 perf build: Gracefully fail the build if BUILD_BPF_SKEL=1 is specified and clang isn't available 5f0b89e632ed81b6 perf test java symbol: Remove needless debuginfod queries 327daf34554d20a6 perf parse-events: Don't reorder ungrouped events by PMU ccc66c6092802d68 perf metric: JSON flag to not group events if gathering a metric group 1b114824106ca468 perf stat: Introduce skippable evsels 2a939c8695035b11 perf metric: Change divide by zero and !support events behavior ⬢[acme@toolbox perf-tools]$ Please help me test this, Regards, - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E883C7EE22 for ; Wed, 10 May 2023 17:35:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ByScuyNHwLIp2XUGtZ28OEUwfUCz8XKh577H5yiQs5Q=; b=dCQwzDRRgdOkPK 4c0T8utDNye4WjaobpwXhZRlpgdp6GaSwUBIuCwjQHmq6aE9OjPk+RDLTKQm1Fe/p61Laq9UBM+sG 0LIV9wIDmN/ks9lORWU6OyZnBuLtpOX4S9ssqzqtZ5iZFNrN7B3FQbgz2tDCcvFA3Pam+Xrit1EMA ki8IAbv1Jh7PrkYQVzwmR91FJWOCAPTjf93oJEh82odoLFrHEcFLinQmws0kS4w3oFh6YK2QhKhM4 /PWc1RI9s+n37qEhtqQzzs6VaKN/h6LirQgVl3eQo8cuKEY3Kb03A8QAySFAFkM+oqpobEFsjIyNP GQ7iFrISCnMfe0h7mpHw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pwniP-006flm-12; Wed, 10 May 2023 17:35:01 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pwniN-006flc-2Z for linux-riscv@bombadil.infradead.org; Wed, 10 May 2023 17:34:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=fFFM+0v1B9mKKAJBQsaxPYMeqdW5vGWNUbnAOldhxdM=; b=nExb2dldcvAK9HEUSjdpduN86G ecejmlMP7tFgVCPpDB/lnT2K5xNSjsR6uxPdl2WYieMkO2OeAIgVdtB5PeDsF5sCWmJM+r/xsbmaH /3M2qTnoU49sAtnUosJmzHPWsXUl0M92ju+PSTXUhZyr3hCTJzceZ6u3vZBS8KVJuwS4T4kZx60Ex ZTgJD5yIl0COOTFHqqogZ0FFBZeXflSvDm17xMZk0t1jd+OC1oJBkGBN2KttfPTgAHYqD7PuLah7G G0HrF5g4YTq0xAwuUVNm3m7rLbl7Wutk0vo0GAHGbExvzhbboTw9CTChDH5eQWCVmxJrc6cOxjnJS QXEVz0NA==; Received: from [187.19.238.117] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pwniL-00GT4s-UV; Wed, 10 May 2023 17:34:58 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BE0DD403B5; Wed, 10 May 2023 14:34:54 -0300 (-03) Date: Wed, 10 May 2023 14:34:54 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Song Liu , Yang Jihong , Andrii Nakryiko , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH v1] perf build: Add system include paths to BPF builds Message-ID: References: <20230506021450.3499232-1-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230506021450.3499232-1-irogers@google.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org RW0gRnJpLCBNYXkgMDUsIDIwMjMgYXQgMDc6MTQ6NTBQTSAtMDcwMCwgSWFuIFJvZ2VycyBlc2Ny ZXZldToKPiBUaGVyZSBhcmUgaW5zdWZmaWNpZW50IGhlYWRlcnMgaW4gdG9vbHMvaW5jbHVkZSB0 byBzYXRpc2Z5IGJ1aWxkaW5nCj4gQlBGIHByb2dyYW1zIGFuZCB0aGVpciBoZWFkZXIgZGVwZW5k ZW5jaWVzLiBBZGQgdGhlIHN5c3RlbSBpbmNsdWRlCj4gcGF0aHMgZnJvbSB0aGUgbm9uLUJQRiBj bGFuZyBjb21waWxlIHNvIHRoYXQgdGhlc2UgaGVhZGVycyBjYW4gYmUKPiBmb3VuZC4KPiAKPiBU aGlzIGNvZGUgd2FzIHRha2VuIGZyb206Cj4gdG9vbHMvdGVzdGluZy9zZWxmdGVzdHMvYnBmL01h a2VmaWxlCj4gCj4gU2lnbmVkLW9mZi1ieTogSWFuIFJvZ2VycyA8aXJvZ2Vyc0Bnb29nbGUuY29t Pgo+IC0tLQo+ICB0b29scy9wZXJmL01ha2VmaWxlLnBlcmYgfCAyMCArKysrKysrKysrKysrKysr KysrLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ IAo+IGRpZmYgLS1naXQgYS90b29scy9wZXJmL01ha2VmaWxlLnBlcmYgYi90b29scy9wZXJmL01h a2VmaWxlLnBlcmYKPiBpbmRleCA2MWMzM2QxMDBiMmIuLjM3YmVmZGZhOGFjOCAxMDA2NDQKPiAt LS0gYS90b29scy9wZXJmL01ha2VmaWxlLnBlcmYKPiArKysgYi90b29scy9wZXJmL01ha2VmaWxl LnBlcmYKPiBAQCAtMTA1Nyw3ICsxMDU3LDI1IEBAICQoU0tFTF9UTVBfT1VUKSAkKExJQkFQSV9P VVRQVVQpICQoTElCQlBGX09VVFBVVCkgJChMSUJQRVJGX09VVFBVVCkgJChMSUJTVUJDTURfCj4g IAo+ICBpZm5kZWYgTk9fQlBGX1NLRUwKClNvIHRoaXMgcGF0Y2ggd2FzIGRvbmUgYmVmb3JlIHRo ZSByZXZlcnRzLCBJIGFkanVzdGVkIGl0IHRvIHdoYXQgaXMKdXBzdHJlYW0gYW5kIHRvIGFub3Ro ZXIgcGF0Y2ggdGhhdCBtYWtlcyB0aGUgYnVpbGQgdXNlIHRoZSBoZWFkZXJzIGZyb20KdGhlIHBl cmYgc291cmNlcyBpbnN0ZWFkIG9mIHRoZSBzeXN0ZW0ncyAobGludXgvYnBmLmggYW5kCmxpbnV4 L3BlcmZfZXZlbnQuaCwgZnJvbSB2bWxpbnV4LmgpLCBwbGVhc2UgdGFrZSBhIGxvb2sgYXQgdGhl IHBhdGNoCmJlbG93LCBJJ20gYWxzbyB0cnlpbmcgdG8gZmlndXJlIG91dCB0aGF0IG90aGVyIHBy b2JsZW0geW91IHBvaW50ZWQgd2l0aApsaW51eC90eXBlcy5zIDotXAoKV2hhdCBJIGhhdmUgbm93 IGluIHRtcC5wZXJmLXRvb2xzOgoK4qyiW2FjbWVAdG9vbGJveCBwZXJmLXRvb2xzXSQgZ2l0IGxv ZyAtLW9uZWxpbmUgdG9ydmFsZHMvbWFzdGVyLi4KYTJhZjBmNmI4ZWY3ZWE0MCAoSEVBRCAtPiBw ZXJmLXRvb2xzKSBwZXJmIGJ1aWxkOiBBZGQgc3lzdGVtIGluY2x1ZGUgcGF0aHMgdG8gQlBGIGJ1 aWxkcwo1YmU2Y2VjZGEwODAyZjIzIHBlcmYgYnBmIHNrZWxzOiBNYWtlIHZtbGludXguaCB1c2Ug YnBmLmggYW5kIHBlcmZfZXZlbnQuaCBpbiBzb3VyY2UgZGlyZWN0b3J5CjdkMTYxMTY1ZDkwNzJk Y2IgcGVyZiBwYXJzZS1ldmVudHM6IERvIG5vdCBicmVhayB1cCBBVVggZXZlbnQgZ3JvdXAKYTQ2 ODA4NTAxMWVhOGJiYSBwZXJmIHRlc3QgdGVzdF9pbnRlbF9wdC5zaDogVGVzdCBzYW1wbGUgbW9k ZSB3aXRoIGV2ZW50IHdpdGggUE1VIG5hbWUKMTIzMzYxNjU5ZmE0MDVkZSBwZXJmIGV2c2VsOiBN b2RpZnkgZ3JvdXAgcG11IG5hbWUgZm9yIHNvZnR3YXJlIGV2ZW50cwozNGU4Mjg5MWQ5OTVhYjg5 IHRvb2xzIGFyY2ggeDg2OiBTeW5jIHRoZSBtc3ItaW5kZXguaCBjb3B5IHdpdGggdGhlIGtlcm5l bCBzb3VyY2VzCjcwNTA0OWNhNGY1YjdiMDAgdG9vbHMgaGVhZGVycyBrdm06IFN5bmMgdWFwaS97 YXNtL2xpbnV4fSBrdm0uaCBoZWFkZXJzIHdpdGggdGhlIGtlcm5lbCBzb3VyY2VzCjhkNmE0MWM4 MDY1ZTExMjAgdG9vbHMgaW5jbHVkZSBVQVBJOiBTeW5jIHRoZSBzb3VuZC9hc291bmQuaCBjb3B5 IHdpdGggdGhlIGtlcm5lbCBzb3VyY2VzCjkyYjhlNjFlODgzNTEwOTEgdG9vbHMgaGVhZGVycyBV QVBJOiBTeW5jIHRoZSBsaW51eC9jb25zdC5oIHdpdGggdGhlIGtlcm5lbCBoZWFkZXJzCmU3ZWMz YTI0OWMzOGE5YzkgdG9vbHMgaGVhZGVycyBVQVBJOiBTeW5jIHRoZSBpOTE1X2RybS5oIHdpdGgg dGhlIGtlcm5lbCBzb3VyY2VzCmU2MjMyMTgwZTUyNGUxMTIgdG9vbHMgaGVhZGVycyBVQVBJOiBT eW5jIHRoZSBkcm0vZHJtLmggd2l0aCB0aGUga2VybmVsIHNvdXJjZXMKNWQxYWM1OWZmNzQ0NWU1 MSB0b29scyBoZWFkZXJzIFVBUEk6IFN5bmMgdGhlIGxpbnV4L2luLmggd2l0aCB0aGUga2VybmVs IHNvdXJjZXMKYjA2MThmMzhlMmFiOGNlMyBwZXJmIGJ1aWxkOiBHcmFjZWZ1bGx5IGZhaWwgdGhl IGJ1aWxkIGlmIEJVSUxEX0JQRl9TS0VMPTEgaXMgc3BlY2lmaWVkIGFuZCBjbGFuZyBpc24ndCBh dmFpbGFibGUKNWYwYjg5ZTYzMmVkODFiNiBwZXJmIHRlc3QgamF2YSBzeW1ib2w6IFJlbW92ZSBu ZWVkbGVzcyBkZWJ1Z2luZm9kIHF1ZXJpZXMKMzI3ZGFmMzQ1NTRkMjBhNiBwZXJmIHBhcnNlLWV2 ZW50czogRG9uJ3QgcmVvcmRlciB1bmdyb3VwZWQgZXZlbnRzIGJ5IFBNVQpjY2M2NmM2MDkyODAy ZDY4IHBlcmYgbWV0cmljOiBKU09OIGZsYWcgdG8gbm90IGdyb3VwIGV2ZW50cyBpZiBnYXRoZXJp bmcgYSBtZXRyaWMgZ3JvdXAKMWIxMTQ4MjQxMDZjYTQ2OCBwZXJmIHN0YXQ6IEludHJvZHVjZSBz a2lwcGFibGUgZXZzZWxzCjJhOTM5Yzg2OTUwMzViMTEgcGVyZiBtZXRyaWM6IENoYW5nZSBkaXZp ZGUgYnkgemVybyBhbmQgIXN1cHBvcnQgZXZlbnRzIGJlaGF2aW9yCuKsolthY21lQHRvb2xib3gg cGVyZi10b29sc10kCgpQbGVhc2UgaGVscCBtZSB0ZXN0IHRoaXMsCgpSZWdhcmRzLAoKLSBBcm5h bGRvCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK