From: Matt Atwood <matthew.s.atwood@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
<intel-xe@lists.freedesktop.org>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 1/4] fixup! drm/xe/display: Implement display support
Date: Wed, 10 May 2023 14:01:10 -0700 [thread overview]
Message-ID: <ZFwGFmwJseFPGwIv@msatwood-mobl> (raw)
In-Reply-To: <20230510195424.3045127-2-lucas.demarchi@intel.com>
On Wed, May 10, 2023 at 12:54:21PM -0700, Lucas De Marchi wrote:
> Remove a bunch of ; that shouldn't be there.
>
Reviewed-by: Matt Atwood <matthew.s.atwood@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/gpu/drm/xe/xe_display.h | 38 ++++++++++++++++-----------------
> 1 file changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_display.h b/drivers/gpu/drm/xe/xe_display.h
> index d1af8e3a5c0f..84c556111c91 100644
> --- a/drivers/gpu/drm/xe/xe_display.h
> +++ b/drivers/gpu/drm/xe/xe_display.h
> @@ -56,36 +56,36 @@ xe_display_create(struct xe_device *xe) { return 0; }
> static inline void xe_display_info_init(struct xe_device *xe) { }
>
> static inline int
> -xe_display_enable(struct pci_dev *pdev, struct drm_driver *driver) { return 0; };
> +xe_display_enable(struct pci_dev *pdev, struct drm_driver *driver) { return 0; }
>
> static inline int
> -xe_display_init_nommio(struct xe_device *xe) { return 0; };
> -static inline void xe_display_fini_nommio(struct drm_device *dev, void *dummy) {};
> +xe_display_init_nommio(struct xe_device *xe) { return 0; }
> +static inline void xe_display_fini_nommio(struct drm_device *dev, void *dummy) {}
>
> static inline int xe_display_init_noirq(struct xe_device *xe) { return 0; }
>
> static inline void
> -xe_display_fini_noirq(struct drm_device *dev, void *dummy) {};
> +xe_display_fini_noirq(struct drm_device *dev, void *dummy) {}
>
> -static inline int xe_display_init_noaccel(struct xe_device *xe) { return 0; };
> -static inline void xe_display_fini_noaccel(struct drm_device *dev, void *dummy) {};
> +static inline int xe_display_init_noaccel(struct xe_device *xe) { return 0; }
> +static inline void xe_display_fini_noaccel(struct drm_device *dev, void *dummy) {}
>
> -static inline int xe_display_init(struct xe_device *xe) { return 0; };
> -static inline void xe_display_unlink(struct xe_device *xe) {};
> +static inline int xe_display_init(struct xe_device *xe) { return 0; }
> +static inline void xe_display_unlink(struct xe_device *xe) {}
>
> -static inline void xe_display_register(struct xe_device *xe) {};
> -static inline void xe_display_unregister(struct xe_device *xe) {};
> -static inline void xe_display_modset_driver_remove(struct xe_device *xe) {};
> +static inline void xe_display_register(struct xe_device *xe) {}
> +static inline void xe_display_unregister(struct xe_device *xe) {}
> +static inline void xe_display_modset_driver_remove(struct xe_device *xe) {}
>
> -static inline void xe_display_irq_handler(struct xe_device *xe, u32 master_ctl) {};
> -static inline void xe_display_irq_enable(struct xe_device *xe, u32 gu_misc_iir) {};
> -static inline void xe_display_irq_reset(struct xe_device *xe) {};
> -static inline void xe_display_irq_postinstall(struct xe_device *xe, struct xe_gt *gt) {};
> +static inline void xe_display_irq_handler(struct xe_device *xe, u32 master_ctl) {}
> +static inline void xe_display_irq_enable(struct xe_device *xe, u32 gu_misc_iir) {}
> +static inline void xe_display_irq_reset(struct xe_device *xe) {}
> +static inline void xe_display_irq_postinstall(struct xe_device *xe, struct xe_gt *gt) {}
>
> -static inline void xe_display_pm_suspend(struct xe_device *xe) {};
> -static inline void xe_display_pm_suspend_late(struct xe_device *xe) {};
> -static inline void xe_display_pm_resume_early(struct xe_device *xe) {};
> -static inline void xe_display_pm_resume(struct xe_device *xe) {};
> +static inline void xe_display_pm_suspend(struct xe_device *xe) {}
> +static inline void xe_display_pm_suspend_late(struct xe_device *xe) {}
> +static inline void xe_display_pm_resume_early(struct xe_device *xe) {}
> +static inline void xe_display_pm_resume(struct xe_device *xe) {}
>
> #endif /* CONFIG_DRM_XE_DISPLAY */
> #endif /* _XE_DISPLAY_H_ */
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-05-10 21:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 19:54 [Intel-xe] [PATCH 0/4] Fix display integration for ATS-M Lucas De Marchi
2023-05-10 19:54 ` [Intel-xe] [PATCH 1/4] fixup! drm/xe/display: Implement display support Lucas De Marchi
2023-05-10 21:01 ` Matt Atwood [this message]
2023-05-10 19:54 ` [Intel-xe] [PATCH 2/4] drm/xe: Annotate desc of platforms with display Lucas De Marchi
2023-05-10 21:05 ` Matt Atwood
2023-05-10 19:54 ` [Intel-xe] [PATCH 3/4] drm/xe/display: Consider has_display to enable it Lucas De Marchi
2023-05-10 21:07 ` Matt Atwood
2023-05-11 12:47 ` Souza, Jose
2023-05-11 15:34 ` Jani Nikula
2023-05-11 17:12 ` Lucas De Marchi
2023-05-11 17:12 ` Lucas De Marchi
2023-05-11 17:22 ` Souza, Jose
2023-05-11 18:02 ` Lucas De Marchi
2023-05-11 18:28 ` Lucas De Marchi
2023-05-11 20:03 ` Souza, Jose
2023-05-12 6:59 ` Jani Nikula
2023-05-10 19:54 ` [Intel-xe] [PATCH 4/4] drm/xe/display: Use xe_display_driver prefix Lucas De Marchi
2023-05-10 21:31 ` Matt Atwood
2023-05-10 20:13 ` [Intel-xe] ✓ CI.Patch_applied: success for Fix display integration for ATS-M Patchwork
2023-05-10 20:14 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-05-10 20:18 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-05-10 20:40 ` [Intel-xe] ○ CI.BAT: info " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFwGFmwJseFPGwIv@msatwood-mobl \
--to=matthew.s.atwood@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.