From: Simon Horman <simon.horman@corigine.com>
To: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Daniel Golle <daniel@makrotopia.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH RFC net-next 1/7] net: sfp: add helper to modify signal states
Date: Thu, 11 May 2023 12:12:37 +0200 [thread overview]
Message-ID: <ZFy/lQC7rKT7Dde/@corigine.com> (raw)
In-Reply-To: <E1pwhue-001Xo4-K9@rmk-PC.armlinux.org.uk>
On Wed, May 10, 2023 at 12:23:16PM +0100, Russell King (Oracle) wrote:
> There are a couple of locations in the code where we modify
> sfp->state, and then call sfp_set_state(, sfp->state) to update
> the outputs/soft state to control the module. Provide a helper
> which takes a mask and new state so that this is encapsulated in
> one location.
>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-05-11 10:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 11:22 [PATCH RFC net-next 0/7] net: sfp: add support for control of rate selection Russell King (Oracle)
2023-05-10 11:23 ` [PATCH RFC net-next 1/7] net: sfp: add helper to modify signal states Russell King (Oracle)
2023-05-11 10:12 ` Simon Horman [this message]
2023-05-10 11:23 ` [PATCH RFC net-next 2/7] net: sfp: move rtnl lock to cover reading state Russell King (Oracle)
2023-05-11 10:12 ` Simon Horman
2023-05-10 11:23 ` [PATCH RFC net-next 3/7] net: sfp: swap order of rtnl and st_mutex locks Russell King (Oracle)
2023-05-11 10:13 ` Simon Horman
2023-05-10 11:23 ` [PATCH RFC net-next 4/7] net: sfp: move sm_mutex into sfp_check_state() Russell King (Oracle)
2023-05-11 10:13 ` Simon Horman
2023-05-10 11:23 ` [PATCH RFC net-next 5/7] net: sfp: change st_mutex locking Russell King (Oracle)
2023-05-11 10:14 ` Simon Horman
2023-05-10 11:23 ` [PATCH RFC net-next 6/7] net: sfp: add support for setting signalling rate Russell King (Oracle)
2023-05-11 10:14 ` Simon Horman
2023-05-10 11:23 ` [PATCH RFC net-next 7/7] net: sfp: add support for rate selection Russell King (Oracle)
2023-05-11 10:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFy/lQC7rKT7Dde/@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.