All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <simon.horman@corigine.com>
To: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
Cc: netdev@vger.kernel.org, linux-net-drivers@amd.com,
	davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	edumazet@google.com, ecree.xilinx@gmail.com,
	habetsm.xilinx@gmail.com
Subject: Re: [PATCH net] sfc: disable RXFCS and RXALL features by default
Date: Thu, 11 May 2023 15:33:45 +0200	[thread overview]
Message-ID: <ZFzuud+3c1Le+c79@corigine.com> (raw)
In-Reply-To: <20230511094333.38645-1-pieter.jansen-van-vuuren@amd.com>

On Thu, May 11, 2023 at 10:43:33AM +0100, Pieter Jansen van Vuuren wrote:
> By default we would not want RXFCS and RXALL features enabled as they are
> mainly intended for debugging purposes. This does not stop users from
> enabling them later on as needed.
> 
> Fixes: 8e57daf70671 ("sfc_ef100: RX path for EF100")
> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
> Co-developed-by: Edward Cree <ecree.xilinx@gmail.com>
> Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
> Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com>

Thanks Pieter,

looks good to me.

Reviewed-by: Simon Horman <simon.horman@corigine.com>


  reply	other threads:[~2023-05-11 13:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-11  9:43 [PATCH net] sfc: disable RXFCS and RXALL features by default Pieter Jansen van Vuuren
2023-05-11 13:33 ` Simon Horman [this message]
2023-05-12  9:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZFzuud+3c1Le+c79@corigine.com \
    --to=simon.horman@corigine.com \
    --cc=davem@davemloft.net \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=habetsm.xilinx@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-net-drivers@amd.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pieter.jansen-van-vuuren@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.