From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>,
Bjorn Andersson <andersson@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-remoteproc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] remoteproc: stm32: Fix error code in stm32_rproc_parse_dt()
Date: Tue, 23 May 2023 14:05:24 -0600 [thread overview]
Message-ID: <ZG0chM7o2f7gTNyg@p14s> (raw)
In-Reply-To: <6f457246-6446-42cb-81ae-d37221d726b1@kili.mountain>
On Mon, May 22, 2023 at 10:46:11AM +0300, Dan Carpenter wrote:
> There is a cut and paste bug so this code was returning the wrong
> variable. It should have been "ddata->hold_boot_rst" instead of
> "ddata->rst".
>
> Fixes: de598695a2ad ("remoteproc: stm32: Allow hold boot management by the SCMI reset controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/remoteproc/stm32_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 0e322697d210..a7457777aae4 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -755,7 +755,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
>
> ddata->hold_boot_rst = devm_reset_control_get_optional(dev, "hold_boot");
> if (IS_ERR(ddata->hold_boot_rst))
> - return dev_err_probe(dev, PTR_ERR(ddata->rst),
> + return dev_err_probe(dev, PTR_ERR(ddata->hold_boot_rst),
> "failed to get hold_boot reset\n");
I have applied this patch.
Thanks,
Mathieu
>
> if (!ddata->hold_boot_rst && IS_ENABLED(CONFIG_HAVE_ARM_SMCCC)) {
> --
> 2.39.2
>
prev parent reply other threads:[~2023-05-23 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 7:46 [PATCH] remoteproc: stm32: Fix error code in stm32_rproc_parse_dt() Dan Carpenter
2023-05-22 14:35 ` Arnaud POULIQUEN
2023-05-23 20:05 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG0chM7o2f7gTNyg@p14s \
--to=mathieu.poirier@linaro.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=arnaud.pouliquen@foss.st.com \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.