From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:d7a2:b0:96f:a786:ac5c with SMTP id pk2csp369458ejb; Thu, 25 May 2023 04:34:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6GM+aoTw+q0ASucpul/vxW01zobGytWKL7Mscq9+bNlOtSG3VDkMBkfsDTKdtdb7Zi8H9z X-Received: by 2002:ac8:5910:0:b0:3f5:2549:3355 with SMTP id 16-20020ac85910000000b003f525493355mr30814111qty.43.1685014470073; Thu, 25 May 2023 04:34:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685014470; cv=none; d=google.com; s=arc-20160816; b=agehMpc7Vom5wxmQWqUv3GZ0bUoy+NVMJ7f7+fk7nBOaEj5U7rNW0p+4QtzgqUSpMW +B9M1O0ARct1MnkoaFdB/KbExHnbWj4g7pTIVak6yZFFzlVnCNpNMT0sy5G6QHaCO0me dTxRoBI+ZYR0iIKrQhgxxw5JRre2R20h3XUjKZGCZwh4RL+wuhLWQsvqI8zUxmfuh3cW 1vCZe/yDeeGwtzcPbmgRBIaTwcTZpVdlDsC7hW4xjHeBbiiBYiDCdbP0Uh4IyzFGtA+0 24a9qAI5btSlvCLnOSpUI0aIAViHsIBs9t4ptwwLJiBEn4vs1GjVoqu1WZQ/A6CJQpeD LdHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :feedback-id:dkim-signature:dkim-signature; bh=A1EUSiH05ybJpEadn0UkunleNidrximLxi3rOwhFAeY=; b=RW2z/hYVONRftoP2gdc+ik1/8lws3FHPFWhMDYRs1QMSRpZSl2DlOjPfUHLmHqZqlh OXzB4UgbdRMQeJr9P6IOR2UJv1Vc8C54tmaBUq1lRaNOyWJ3xVOyNg4XWfTx/6qBDD4x S9WaMI4dmQMf6OGy7bZRgGiK7JjFyKHFLIFIjZ/HZPMTZ4piZH9ADGITBiMS620w4VcN n2vsuNHuoShsM7r5601s+eYaA/tc25y8CyXwo9IWOXdq6E2NkgLbiss23Saww3zWB/FA aMsYgz+zfq3WG8IcZZ2uhVwLWG4jkgLQlhwFZoC/0yCoLIREPTxPerbjm1BFcZpgFWMO HvDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@irrelevant.dk header.s=fm3 header.b=XdV7DSgh; dkim=fail header.i=@messagingengine.com header.s=fm1 header.b=utdajSZL; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y17-20020a05622a121100b003f4f5bfe7a3si378702qtx.31.2023.05.25.04.34.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 May 2023 04:34:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@irrelevant.dk header.s=fm3 header.b=XdV7DSgh; dkim=fail header.i=@messagingengine.com header.s=fm1 header.b=utdajSZL; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q29EQ-0006cq-Ds; Thu, 25 May 2023 07:34:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q29EO-0006bM-80; Thu, 25 May 2023 07:34:08 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q29EL-0002CE-PS; Thu, 25 May 2023 07:34:08 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id ADC0932003C0; Thu, 25 May 2023 07:33:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 May 2023 07:33:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1685014438; x= 1685100838; bh=A1EUSiH05ybJpEadn0UkunleNidrximLxi3rOwhFAeY=; b=X dV7DSghp/EEUUS6T/E5DzXcAxhSTbP4yqeQIwfDOyszPJeOGhMOCMDBtY3mLBVJW k6iPug57dp4SF16hjYXBuM9aBQo6dHRPnJYkQ0RajUnoQMeJhx8FbDUngSxGdRze mmBlaubWO5MFgQQFDBr1USd9eFoyW6x5+sgvJ5+S6mQSeRmsLBEf3dAMnsI/MhTY 4mCNzlu+UyIwdaFkgVXuQBCPU03h7+pm4V/MLZRg/cOAGO+Kb6dr6Qsbtf+iO6oF KsaY3X90e/oUivVIPf2kZz41bdoFdGeVJ9LoOFR0hmJJjIr91ArTu/Hitw23ulQm 98T6zpSsaTs0mcqlNaGEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1685014438; x=1685100838; bh=A1EUSiH05ybJp Eadn0UkunleNidrximLxi3rOwhFAeY=; b=utdajSZL01/fLQ8SSkXHZegbfBwYY CnTuy6NEA7mvkzSNlHCmX1+lbpo2K1/UtCEsai6zFFXJtV99mq/EeEtiOUxn9oif vzhDHSu6MBHAllPypp+FDZa3E8X/Dl2eN9fiiiSJsi33pBE1NfepnGD1RN8dDmLY PJfBU7QWdp0DdlaJAQrhpesOwS06l8buRv5TgHR6nDnPUL7tBY4gSTa1yqDnGTQz D+2QcRclvxk+N94a4pxMBkxGqBXZN2soq4SYWIiKdcTatworOIDlgwsukmec/NoQ 0RSlQhW78u7Q9Y/uXBaeNaefiS8hjJ/k4YL0/W3fe0SnN5SLrppMYsjUQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejjedggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepmfhlrghu shculfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrth htvghrnhepffduvdfhheejudfgieejueeileegveduvdelhfekhffgteetffdtvdekveei leefnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Feedback-ID: idc91472f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 25 May 2023 07:33:54 -0400 (EDT) Date: Thu, 25 May 2023 13:33:52 +0200 From: Klaus Jensen To: Jonathan Cameron Cc: qemu-devel@nongnu.org, Corey Minyard , Jeremy Kerr , qemu-arm@nongnu.org, Peter Delevoryas , Keith Busch , =?utf-8?Q?C=C3=A9dric?= Le Goater , Jason Wang , Lior Weintraub , qemu-block@nongnu.org, Peter Maydell , Matt Johnston , Klaus Jensen Subject: Re: [PATCH v2 1/3] hw/i2c: add mctp core Message-ID: References: <20230425063540.46143-1-its@irrelevant.dk> <20230425063540.46143-2-its@irrelevant.dk> <20230525122711.00002a61@Huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8ZwLm31Fr6bPAHsP" Content-Disposition: inline In-Reply-To: <20230525122711.00002a61@Huawei.com> Received-SPF: pass client-ip=64.147.123.24; envelope-from=its@irrelevant.dk; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: y0IRQi9Sz9mc --8ZwLm31Fr6bPAHsP Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On May 25 12:27, Jonathan Cameron wrote: > On Tue, 25 Apr 2023 08:35:38 +0200 > Klaus Jensen wrote: >=20 > > From: Klaus Jensen > >=20 > > Add an abstract MCTP over I2C endpoint model. This implements MCTP > > control message handling as well as handling the actual I2C transport > > (packetization). > >=20 > > Devices are intended to derive from this and implement the class > > methods. > >=20 > > Parts of this implementation is inspired by code[1] previously posted by > > Jonathan Cameron. > >=20 > > [1]: https://lore.kernel.org/qemu-devel/20220520170128.4436-1-Jonatha= n.Cameron@huawei.com/ > >=20 > > Signed-off-by: Klaus Jensen >=20 > This is very useful for the CXL MCTP CCI support - got rid of most of the > nasty code when I moved over to using this (will post code shortly) >=20 > A few comments inline - but all trivial stuff. >=20 > What I can give now though is: > Tested-by: Jonathan Cameron >=20 Hi Jonathan, This came at just the right time! I was finally preparing v3 since Lior is also requesting that this gets merged sooner rather than later ;) I'll work in your very resonable comments (thanks!) and ship it. Thanks again, Klaus --8ZwLm31Fr6bPAHsP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmRvR58ACgkQTeGvMW1P Dem5wAgAgd0shlQK2sUpGuTmGXBGFdi3vmQxPihacby/QkvzzHrzMFXl6xPc3sx+ a6v3lQ0WWBhc9uN0v/ZeXvwN3CVkLJIOBAyyRDYSJOeQi9ZhL70dLlf5TPe+J3AR FBuO08jWVfipMCuMxsUJKlv94iS1MqQ2egh54ziWMMKpZ9qRvtQLPFacLPKoDWpX 3gveU+XewSYjovt74ZR+tUire0KrnFuAflI/XE3+OuQEDruMl7ZuTF8W9y7HTSba 4jZMz1q12kkJIp06lvsVW4HsmZEHxRKE0wdGF6xr4rxrW/uZROPwcdEu+7V+hZJU 3vFRK9tJx81y2BuTMpBZUVluT1KTRw== =1OCM -----END PGP SIGNATURE----- --8ZwLm31Fr6bPAHsP--