All of lore.kernel.org
 help / color / mirror / Atom feed
From: Duncan Roe <duncan_roe@optusnet.com.au>
To: Florian Westphal <fw@strlen.de>
Cc: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: ct state vmap no longer works on 6.3 kernel
Date: Tue, 16 May 2023 11:03:07 +1000	[thread overview]
Message-ID: <ZGLWS4mWN0KeGbr1@slk15.local.net> (raw)
In-Reply-To: <9252665d-7d18-099f-dad2-e3ee882591fd@rvf6.com>

On Wed, May 03, 2023 at 07:33:35PM +0800, Rvfg wrote:
>
>
> On 5/3/23 16:19, Florian Westphal wrote:
> > Thanks, the BREAK in the referenced patch is the problem.
> >
> > Please give this fix a try:
> >
> > diff --git a/net/netfilter/nft_ct_fast.c b/net/netfilter/nft_ct_fast.c
> > --- a/net/netfilter/nft_ct_fast.c
> > +++ b/net/netfilter/nft_ct_fast.c
> > @@ -15,10 +15,6 @@ void nft_ct_get_fast_eval(const struct nft_expr *expr,
> >   	unsigned int state;
> >   	ct = nf_ct_get(pkt->skb, &ctinfo);
> > -	if (!ct) {
> > -		regs->verdict.code = NFT_BREAK;
> > -		return;
> > -	}
> >   	switch (priv->key) {
> >   	case NFT_CT_STATE:
> > @@ -30,6 +26,16 @@ void nft_ct_get_fast_eval(const struct nft_expr *expr,
> >   			state = NF_CT_STATE_INVALID_BIT;
> >   		*dest = state;
> >   		return;
> > +	default:
> > +		break;
> > +	}
> > +
> > +	if (!ct) {
> > +		regs->verdict.code = NFT_BREAK;
> > +		return;
> > +	}
> > +
> > +	switch (priv->key) {
> >   	case NFT_CT_DIRECTION:
> >   		nft_reg_store8(dest, CTINFO2DIR(ctinfo));
> >   		return;
>
> This patch fixed my problem on 6.3.0 kernel. Thank you!

I don't see this patch in 6.3.2. Is it in the queue anywhere?

Cheers ... Duncan.

      reply	other threads:[~2023-05-16  1:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-01 13:58 ct state vmap no longer works on 6.3 kernel Rvfg
2023-05-03  6:19 ` Pablo Neira Ayuso
2023-05-03  7:49   ` Rvfg
2023-05-03  8:19     ` Florian Westphal
2023-05-03 11:33       ` Rvfg
2023-05-16  1:03         ` Duncan Roe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZGLWS4mWN0KeGbr1@slk15.local.net \
    --to=duncan_roe@optusnet.com.au \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.