From: Jason Gunthorpe <jgg@nvidia.com>
To: liulongfang <liulongfang@huawei.com>
Cc: alex.williamson@redhat.com, shameerali.kolothum.thodi@huawei.com,
jonathan.cameron@huawei.com, cohuck@redhat.com,
linux-kernel@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [PATCH v10 3/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver
Date: Tue, 16 May 2023 08:50:45 -0300 [thread overview]
Message-ID: <ZGNuFYQJz488Xrdr@nvidia.com> (raw)
In-Reply-To: <fa3d47a1-0af5-f8ba-d14c-8d9a756e2c23@huawei.com>
On Tue, May 16, 2023 at 05:40:36PM +0800, liulongfang wrote:
> On 2023/4/21 22:31, Jason Gunthorpe wrote:
> > On Fri, Apr 21, 2023 at 11:32:47AM +0800, liulongfang wrote:
> >
> >> Thank you for your suggestion, but the current debugfs method can already
> >> meet the functional requirements of verification testing and
> >> problem location.
> >
> > To be clear, I'm against adding selftest code in this manner. We have
> > many frameworks for kernel teesting, please pick one and integrate
> > with it.
> >
>
> Hi, Jason:
> The purpose of this hisi_acc_vf_debug_restore function is to obtain the
> migration status data of the migration device. It is a debug operation.
> Just to obtain this status data, user need to complete the few steps
> of live migration.
> Therefore, it is a debug function here, not a self-test function.
A debug function should not alter the device state, or do a trial migration.
Jason
next prev parent reply other threads:[~2023-05-16 11:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 7:42 [PATCH v10 0/5] add debugfs to migration driver Longfang Liu
2023-04-08 7:42 ` [PATCH v10 1/5] vfio/migration: Add debugfs to live " Longfang Liu
2023-04-08 7:42 ` [PATCH v10 2/5] hisi_acc_vfio_pci: extract public functions for container_of Longfang Liu
2023-04-08 7:42 ` [PATCH v10 3/5] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver Longfang Liu
2023-04-14 12:24 ` Jason Gunthorpe
2023-04-21 3:27 ` liulongfang
2023-04-21 3:32 ` liulongfang
2023-04-21 14:31 ` Jason Gunthorpe
2023-05-16 9:40 ` liulongfang
2023-05-16 10:50 ` liulongfang
2023-05-16 11:50 ` Jason Gunthorpe [this message]
2023-06-02 7:07 ` liulongfang
2023-04-08 7:42 ` [PATCH v10 4/5] Documentation: add debugfs description for vfio Longfang Liu
2023-04-08 7:42 ` [PATCH v10 5/5] vfio: update live migration device status Longfang Liu
2023-04-14 12:25 ` Jason Gunthorpe
2023-04-21 3:07 ` liulongfang
2023-04-21 14:30 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGNuFYQJz488Xrdr@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=liulongfang@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.