From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E98AC77B7A for ; Tue, 16 May 2023 13:36:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233659AbjEPNgx (ORCPT ); Tue, 16 May 2023 09:36:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233453AbjEPNgr (ORCPT ); Tue, 16 May 2023 09:36:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E212527B; Tue, 16 May 2023 06:36:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2A476617FF; Tue, 16 May 2023 13:36:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9985C433EF; Tue, 16 May 2023 13:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684244203; bh=y/yWoPs8Nlf4p3CTjaVQfoHaJvHxuvjvDqaUL6F6Phs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UjFmnmvm35D7Eoud6qOlQMYj0uS3SPPHJcIUVr0C9BDKoibiNK8iuxNXsMfN8dUcl mVm73t4opsFn4yO0j6dumM+xej3qJCNa76TPN9pFSHIrzPk4gJY7dHx3ArwaUhJG1m mRMvXSsr3sblzY1w38uCi8+ho8rBSWj6yui36whSEGEQVWI+NM8vEvEK5OL22MkFi3 FncsH9nsj40e6PPPzWlCBVz6ymCuBSDoD79oWbiprWq/5FEmdYM2tn2UwaLT5z5q1k ZIMNJVjtmipsCnGvhlqqu+G63uKI6zGkdoKe4c6qBlY8PSExWjIhu9bTYaUozT7pua 0TiA4WuBanyaA== Date: Tue, 16 May 2023 19:06:38 +0530 From: Vinod Koul To: Sean Anderson Cc: Kishon Vijay Abraham I , linux-phy@lists.infradead.org, Madalin Bucur , linux-arm-kernel@lists.infradead.org, Camelia Alexandra Groza , devicetree@vger.kernel.org, Rob Herring , linuxppc-dev@lists.ozlabs.org, Bagas Sanjaya , Krzysztof Kozlowski , Ioana Ciornei , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v14 07/15] phy: fsl: Add Lynx 10G SerDes driver Message-ID: References: <20230413160607.4128315-1-sean.anderson@seco.com> <20230413160607.4128315-8-sean.anderson@seco.com> <957a6bb4-f07b-f511-72c9-da4199dc8616@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <957a6bb4-f07b-f511-72c9-da4199dc8616@seco.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 08-05-23, 11:28, Sean Anderson wrote: > On 5/8/23 05:22, Vinod Koul wrote: > > On 13-04-23, 12:05, Sean Anderson wrote: > >> +static const struct lynx_cfg ls1088a_cfg = { > >> + .lanes = 4, > >> + .endian = REGMAP_ENDIAN_LITTLE, > >> + .mode_conflict = lynx_ls_mode_conflict, > >> + .mode_apply = lynx_ls_mode_apply, > >> + .mode_init = lynx_ls_mode_init, > > > > So you have cfg with mode_xxx pointing to same functions for both of the > > versions you support... so question is why do this and not call the > > functions directly? > > The intention is to make it easy to add support for T-series processors, > which have a different PCCR layout. And when is that going to come. I would prefer this to be added when we have users being added -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5FCFC77B7A for ; Tue, 16 May 2023 13:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VnKyAq8AYnoVlGQ5QOHdvUg4Sh3aNW6hWwDRYN2l4rA=; b=md4LfIDSkNVdmR 5CJggRNyQPO3R2JqJ+qiqPIRw1qcWvomYpsA03VsHkRH3Q474ucoH045NDpZHZu6uKAL8Z1XScYIr V/BhNAahY4R/9JB6MP5NyzXtcFKqmXPr2JIbPyLXcrOfqoOVC5RarR4LAiQ3zT7F9OAY0I4vnKSc+ pzzihigqWiVhbNPskMbzyWsde0h7ECNqgs8HYfm5HjxXU/yHG+GVfx5EkDwRkPXRrYXNL/PN4YW8U 2cdLVPHPL2IxOv548+H6Cw6zkolj1AXMjIF7frQ4GutrdpsV5Bi4rh6fzyuMbESFbKesktHky6UVy ue8jibcllyNdBwcWZaow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyur9-005wNJ-1W; Tue, 16 May 2023 13:36:47 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyur6-005wM7-1m; Tue, 16 May 2023 13:36:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1315661904; Tue, 16 May 2023 13:36:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9985C433EF; Tue, 16 May 2023 13:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684244203; bh=y/yWoPs8Nlf4p3CTjaVQfoHaJvHxuvjvDqaUL6F6Phs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UjFmnmvm35D7Eoud6qOlQMYj0uS3SPPHJcIUVr0C9BDKoibiNK8iuxNXsMfN8dUcl mVm73t4opsFn4yO0j6dumM+xej3qJCNa76TPN9pFSHIrzPk4gJY7dHx3ArwaUhJG1m mRMvXSsr3sblzY1w38uCi8+ho8rBSWj6yui36whSEGEQVWI+NM8vEvEK5OL22MkFi3 FncsH9nsj40e6PPPzWlCBVz6ymCuBSDoD79oWbiprWq/5FEmdYM2tn2UwaLT5z5q1k ZIMNJVjtmipsCnGvhlqqu+G63uKI6zGkdoKe4c6qBlY8PSExWjIhu9bTYaUozT7pua 0TiA4WuBanyaA== Date: Tue, 16 May 2023 19:06:38 +0530 From: Vinod Koul To: Sean Anderson Cc: Kishon Vijay Abraham I , linux-phy@lists.infradead.org, Madalin Bucur , linux-arm-kernel@lists.infradead.org, Camelia Alexandra Groza , devicetree@vger.kernel.org, Rob Herring , linuxppc-dev@lists.ozlabs.org, Bagas Sanjaya , Krzysztof Kozlowski , Ioana Ciornei , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v14 07/15] phy: fsl: Add Lynx 10G SerDes driver Message-ID: References: <20230413160607.4128315-1-sean.anderson@seco.com> <20230413160607.4128315-8-sean.anderson@seco.com> <957a6bb4-f07b-f511-72c9-da4199dc8616@seco.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <957a6bb4-f07b-f511-72c9-da4199dc8616@seco.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_063644_629480_E2E1346B X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 08-05-23, 11:28, Sean Anderson wrote: > On 5/8/23 05:22, Vinod Koul wrote: > > On 13-04-23, 12:05, Sean Anderson wrote: > >> +static const struct lynx_cfg ls1088a_cfg = { > >> + .lanes = 4, > >> + .endian = REGMAP_ENDIAN_LITTLE, > >> + .mode_conflict = lynx_ls_mode_conflict, > >> + .mode_apply = lynx_ls_mode_apply, > >> + .mode_init = lynx_ls_mode_init, > > > > So you have cfg with mode_xxx pointing to same functions for both of the > > versions you support... so question is why do this and not call the > > functions directly? > > The intention is to make it easy to add support for T-series processors, > which have a different PCCR layout. And when is that going to come. I would prefer this to be added when we have users being added -- ~Vinod -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20F84C77B75 for ; Tue, 16 May 2023 13:38:17 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QLHPL6Y4Pz3fDW for ; Tue, 16 May 2023 23:38:14 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=UjFmnmvm; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=vkoul@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=UjFmnmvm; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QLHMd5sgJz3f7v for ; Tue, 16 May 2023 23:36:45 +1000 (AEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1315661904; Tue, 16 May 2023 13:36:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9985C433EF; Tue, 16 May 2023 13:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684244203; bh=y/yWoPs8Nlf4p3CTjaVQfoHaJvHxuvjvDqaUL6F6Phs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UjFmnmvm35D7Eoud6qOlQMYj0uS3SPPHJcIUVr0C9BDKoibiNK8iuxNXsMfN8dUcl mVm73t4opsFn4yO0j6dumM+xej3qJCNa76TPN9pFSHIrzPk4gJY7dHx3ArwaUhJG1m mRMvXSsr3sblzY1w38uCi8+ho8rBSWj6yui36whSEGEQVWI+NM8vEvEK5OL22MkFi3 FncsH9nsj40e6PPPzWlCBVz6ymCuBSDoD79oWbiprWq/5FEmdYM2tn2UwaLT5z5q1k ZIMNJVjtmipsCnGvhlqqu+G63uKI6zGkdoKe4c6qBlY8PSExWjIhu9bTYaUozT7pua 0TiA4WuBanyaA== Date: Tue, 16 May 2023 19:06:38 +0530 From: Vinod Koul To: Sean Anderson Subject: Re: [PATCH v14 07/15] phy: fsl: Add Lynx 10G SerDes driver Message-ID: References: <20230413160607.4128315-1-sean.anderson@seco.com> <20230413160607.4128315-8-sean.anderson@seco.com> <957a6bb4-f07b-f511-72c9-da4199dc8616@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <957a6bb4-f07b-f511-72c9-da4199dc8616@seco.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kishon Vijay Abraham I , devicetree@vger.kernel.org, Krzysztof Kozlowski , Madalin Bucur , Jonathan Corbet , linux-doc@vger.kernel.org, Rob Herring , Camelia Alexandra Groza , Bagas Sanjaya , Ioana Ciornei , linux-phy@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 08-05-23, 11:28, Sean Anderson wrote: > On 5/8/23 05:22, Vinod Koul wrote: > > On 13-04-23, 12:05, Sean Anderson wrote: > >> +static const struct lynx_cfg ls1088a_cfg = { > >> + .lanes = 4, > >> + .endian = REGMAP_ENDIAN_LITTLE, > >> + .mode_conflict = lynx_ls_mode_conflict, > >> + .mode_apply = lynx_ls_mode_apply, > >> + .mode_init = lynx_ls_mode_init, > > > > So you have cfg with mode_xxx pointing to same functions for both of the > > versions you support... so question is why do this and not call the > > functions directly? > > The intention is to make it easy to add support for T-series processors, > which have a different PCCR layout. And when is that going to come. I would prefer this to be added when we have users being added -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76099C77B7F for ; Tue, 16 May 2023 13:37:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DvvCyBk7YAY4m1jWuz3nYVs4dwBA4pLc50Hhhg6b4TY=; b=Ru/UQ/py2DgKci 44qSy/2lel+J/mTaf9woLZkPAJx28xKyEZ9EQh9jg0Rbmm02AbCzsOE7DP5u/pzR9r+5NpM+1A7hS XvBxglkcbpEi0sw3SFTAkum/WOvjnmnh+yEiqkHdFRWe1VpETwbT7QiywkFdxW8r3jGekz5bZCsQE sWjFC2Z6g6Iw7WiMbdTXd4NEjcx4XHc6z3Z2yJ3FQbiW1muMLEi480afKPfOJN62ayEPzRO//D/eX usRhRWXq715Yxzp+XyJxWeixeIvSig/fYbbM/gpjFP9/yqJdO/XRLbj0ZAd2msAvLXfbIoUhVNl4l GTVcm2pqqC5d2QDOwOJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyur9-005wMn-01; Tue, 16 May 2023 13:36:47 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyur6-005wM7-1m; Tue, 16 May 2023 13:36:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1315661904; Tue, 16 May 2023 13:36:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9985C433EF; Tue, 16 May 2023 13:36:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684244203; bh=y/yWoPs8Nlf4p3CTjaVQfoHaJvHxuvjvDqaUL6F6Phs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UjFmnmvm35D7Eoud6qOlQMYj0uS3SPPHJcIUVr0C9BDKoibiNK8iuxNXsMfN8dUcl mVm73t4opsFn4yO0j6dumM+xej3qJCNa76TPN9pFSHIrzPk4gJY7dHx3ArwaUhJG1m mRMvXSsr3sblzY1w38uCi8+ho8rBSWj6yui36whSEGEQVWI+NM8vEvEK5OL22MkFi3 FncsH9nsj40e6PPPzWlCBVz6ymCuBSDoD79oWbiprWq/5FEmdYM2tn2UwaLT5z5q1k ZIMNJVjtmipsCnGvhlqqu+G63uKI6zGkdoKe4c6qBlY8PSExWjIhu9bTYaUozT7pua 0TiA4WuBanyaA== Date: Tue, 16 May 2023 19:06:38 +0530 From: Vinod Koul To: Sean Anderson Cc: Kishon Vijay Abraham I , linux-phy@lists.infradead.org, Madalin Bucur , linux-arm-kernel@lists.infradead.org, Camelia Alexandra Groza , devicetree@vger.kernel.org, Rob Herring , linuxppc-dev@lists.ozlabs.org, Bagas Sanjaya , Krzysztof Kozlowski , Ioana Ciornei , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH v14 07/15] phy: fsl: Add Lynx 10G SerDes driver Message-ID: References: <20230413160607.4128315-1-sean.anderson@seco.com> <20230413160607.4128315-8-sean.anderson@seco.com> <957a6bb4-f07b-f511-72c9-da4199dc8616@seco.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <957a6bb4-f07b-f511-72c9-da4199dc8616@seco.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_063644_629480_E2E1346B X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08-05-23, 11:28, Sean Anderson wrote: > On 5/8/23 05:22, Vinod Koul wrote: > > On 13-04-23, 12:05, Sean Anderson wrote: > >> +static const struct lynx_cfg ls1088a_cfg = { > >> + .lanes = 4, > >> + .endian = REGMAP_ENDIAN_LITTLE, > >> + .mode_conflict = lynx_ls_mode_conflict, > >> + .mode_apply = lynx_ls_mode_apply, > >> + .mode_init = lynx_ls_mode_init, > > > > So you have cfg with mode_xxx pointing to same functions for both of the > > versions you support... so question is why do this and not call the > > functions directly? > > The intention is to make it easy to add support for T-series processors, > which have a different PCCR layout. And when is that going to come. I would prefer this to be added when we have users being added -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel