From: Vinod Koul <vkoul@kernel.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: error27@gmail.com, kernel-janitors@vger.kernel.org,
dan.carpenter@linaro.org, Fenghua Yu <fenghua.yu@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Fix passing freed memory in idxd_cdev_open()
Date: Tue, 16 May 2023 23:21:01 +0530 [thread overview]
Message-ID: <ZGPChVyCDwX2wEJs@matsya> (raw)
In-Reply-To: <20230509060716.2830630-1-harshit.m.mogalapalli@oracle.com>
On 08-05-23, 23:07, Harshit Mogalapalli wrote:
> Smatch warns:
> drivers/dma/idxd/cdev.c:327:
> idxd_cdev_open() warn: 'sva' was already freed.
>
> When idxd_wq_set_pasid() fails, the current code unbinds sva and then
> goes to 'failed_set_pasid' where iommu_sva_unbind_device is called
> again causing the above warning.
> [ device_user_pasid_enabled(idxd) is still true when calling
> failed_set_pasid ]
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2023-05-16 17:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 6:07 [PATCH] dmaengine: idxd: Fix passing freed memory in idxd_cdev_open() Harshit Mogalapalli
2023-05-09 15:13 ` Dave Jiang
2023-05-10 22:08 ` Fenghua Yu
2023-05-16 17:51 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGPChVyCDwX2wEJs@matsya \
--to=vkoul@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=error27@gmail.com \
--cc=fenghua.yu@intel.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.