Re: [RFC PATCH v3 08/10] hw/arm/smmuv3: Add CMDs related to stage-2

[Mostafa Saleh <smostafa@google.com>]

On Tue, May 16, 2023 at 07:04:34PM +0200, Eric Auger wrote:
> >>> +            break;
> >>> +        case SMMU_CMD_TLBI_S12_VMALL:
> >>> +            uint16_t vmid = CMD_VMID(&cmd);
> >> I get
> >> ../hw/arm/smmuv3.c: In function ‘smmuv3_cmdq_consume’:
> >> ../hw/arm/smmuv3.c:1295:13: error: a label can only be part of a
> >> statement and a declaration is not a statement
> >>              uint16_t vmid = CMD_VMID(&cmd);
> >>
> >> you should put the case into a block.
> > Thanks for spotting this, I will fix it.
> > Can you please let me know your config/build commands?
> > as I didn't get errors when compiling it.
> I used a very basic config:
> 
> configure --target-list=aarch64-softmmu --enable-kvm
> --enable-trace-backends=log
Thanks Eric, this builds fine for me, it must be a toolchain thing then.

Thanks,
Mostafa