From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: Guoqing Jiang <guoqing.jiang@linux.dev>,
zyjzyj2000@gmail.com, leon@kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/rxe: Convert spin_{lock_bh,unlock_bh} to spin_{lock_irqsave,unlock_irqrestore}
Date: Tue, 16 May 2023 21:39:14 -0300 [thread overview]
Message-ID: <ZGQiMsBAWhyACuxK@nvidia.com> (raw)
In-Reply-To: <5d1aa20f-2cd0-5400-69e9-057ede404ae4@gmail.com>
On Tue, May 16, 2023 at 07:32:35PM -0500, Bob Pearson wrote:
> On 5/16/23 19:11, Jason Gunthorpe wrote:
> > On Wed, May 10, 2023 at 11:50:56AM +0800, Guoqing Jiang wrote:
> >> We need to call spin_lock_irqsave/spin_unlock_irqrestore for state_lock
> >> in rxe, otherwsie the callchain
> >>
> >> ib_post_send_mad
> >> -> spin_lock_irqsave
> >> -> ib_post_send -> rxe_post_send
> >> -> spin_lock_bh
> >> -> spin_unlock_bh
> >> -> spin_unlock_irqrestore
> >>
> >> caused below traces during run block nvmeof-mp/001 test.
> > ..
> >
> >> Fixes: f605f26ea196 ("RDMA/rxe: Protect QP state with qp->state_lock")
> >> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
> >> Reviewed-by: Bob Pearson <rpearsonhpe@gmail.com>
> >> ---
> >> drivers/infiniband/sw/rxe/rxe_comp.c | 26 +++++++++++--------
> >> drivers/infiniband/sw/rxe/rxe_net.c | 7 +++---
> >> drivers/infiniband/sw/rxe/rxe_qp.c | 36 +++++++++++++++++----------
> >> drivers/infiniband/sw/rxe/rxe_recv.c | 9 ++++---
> >> drivers/infiniband/sw/rxe/rxe_req.c | 30 ++++++++++++----------
> >> drivers/infiniband/sw/rxe/rxe_resp.c | 14 ++++++-----
> >> drivers/infiniband/sw/rxe/rxe_verbs.c | 25 ++++++++++---------
> >> 7 files changed, 86 insertions(+), 61 deletions(-)
> >
> > Applied to for-rc, thanks
> >
> > Jason
>
> You didn't mention it but this shouldn't have applied/compiled without
> fixing the overlap of these two patches. ??
oh, I fixed it, it is trivial
Jason
next prev parent reply other threads:[~2023-05-17 0:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 3:50 [PATCH] RDMA/rxe: Convert spin_{lock_bh,unlock_bh} to spin_{lock_irqsave,unlock_irqrestore} Guoqing Jiang
2023-05-16 19:00 ` Bob Pearson
2023-05-17 0:11 ` Jason Gunthorpe
2023-05-17 0:32 ` Bob Pearson
2023-05-17 0:39 ` Jason Gunthorpe [this message]
2023-05-17 0:41 ` Guoqing Jiang
2023-05-17 1:57 ` Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGQiMsBAWhyACuxK@nvidia.com \
--to=jgg@nvidia.com \
--cc=guoqing.jiang@linux.dev \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.