Re: [PATCH net-next] net: liquidio: lio_core: Remove unnecessary (void*) conversions

[Simon Horman <simon.horman@corigine.com>]

On Tue, May 16, 2023 at 08:20:59PM -0700, Jakub Kicinski wrote:
> On Mon, 15 May 2023 22:19:31 +0200 Simon Horman wrote:
> > On Mon, May 15, 2023 at 05:56:21PM +0300, Dan Carpenter wrote:
> > > On Mon, May 15, 2023 at 12:28:19PM +0300, Dan Carpenter wrote:  
> > > > Networking code needs to be in Reverse Christmas Tree order.  Longest
> > > > lines first.  This code wasn't really in Reverse Christmas Tree order
> > > > to begine with but now it's more obvious.  
> > > 
> > > Oh, duh.  This obviously can't be reversed because it depends on the
> > > first declaration.  Sorry for the noise.  
> > 
> > FWIIW, I think the preferred approach for such cases is to
> > separate the declaration and initialisation. Something like:
> > 
> > 	struct octeon_device *oct = droq->oct_dev;
> > 	struct octeon_device_priv *oct_priv;
> > 
> > 	oct_priv = oct->priv;
> 
> I don't think these changes are worth bothering with at all, TBH.

Understood.