From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: mjrosato@linux.ibm.com, jasowang@redhat.com,
xudong.hao@intel.com, zhenzhong.duan@intel.com,
peterx@redhat.com, terrence.xu@intel.com,
chao.p.peng@linux.intel.com, linux-s390@vger.kernel.org,
Yi Liu <yi.l.liu@intel.com>,
kvm@vger.kernel.org, lulu@redhat.com, yanting.jiang@intel.com,
joro@8bytes.org, nicolinc@nvidia.com, yan.y.zhao@intel.com,
intel-gfx@lists.freedesktop.org, eric.auger@redhat.com,
intel-gvt-dev@lists.freedesktop.org, yi.y.sun@linux.intel.com,
clegoate@redhat.com, cohuck@redhat.com,
shameerali.kolothum.thodi@huawei.com,
suravee.suthikulpanit@amd.com, robin.murphy@arm.com
Subject: Re: [Intel-gfx] [PATCH v5 01/10] vfio-iommufd: Create iommufd_access for noiommu devices
Date: Wed, 17 May 2023 15:20:51 -0300 [thread overview]
Message-ID: <ZGUbAzl985p5kX1Z@nvidia.com> (raw)
In-Reply-To: <20230517112609.78a3e916.alex.williamson@redhat.com>
On Wed, May 17, 2023 at 11:26:09AM -0600, Alex Williamson wrote:
> It's not clear to me why we need a separate iommufd_access for
> noiommu.
The point was to allocate an ID for the device so we can use that ID
with the other interfaces in all cases.
Otherwise it is a too weird special case that is probably going to
keep causing trouble down the road...
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Yi Liu <yi.l.liu@intel.com>,
kevin.tian@intel.com, joro@8bytes.org, robin.murphy@arm.com,
cohuck@redhat.com, eric.auger@redhat.com, nicolinc@nvidia.com,
kvm@vger.kernel.org, mjrosato@linux.ibm.com,
chao.p.peng@linux.intel.com, yi.y.sun@linux.intel.com,
peterx@redhat.com, jasowang@redhat.com,
shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
suravee.suthikulpanit@amd.com,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-s390@vger.kernel.org,
xudong.hao@intel.com, yan.y.zhao@intel.com,
terrence.xu@intel.com, yanting.jiang@intel.com,
zhenzhong.duan@intel.com, clegoate@redhat.com
Subject: Re: [PATCH v5 01/10] vfio-iommufd: Create iommufd_access for noiommu devices
Date: Wed, 17 May 2023 15:20:51 -0300 [thread overview]
Message-ID: <ZGUbAzl985p5kX1Z@nvidia.com> (raw)
In-Reply-To: <20230517112609.78a3e916.alex.williamson@redhat.com>
On Wed, May 17, 2023 at 11:26:09AM -0600, Alex Williamson wrote:
> It's not clear to me why we need a separate iommufd_access for
> noiommu.
The point was to allocate an ID for the device so we can use that ID
with the other interfaces in all cases.
Otherwise it is a too weird special case that is probably going to
keep causing trouble down the road...
Jason
next prev parent reply other threads:[~2023-05-17 18:20 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-13 13:21 [Intel-gfx] [PATCH v5 00/10] Enhance vfio PCI hot reset for vfio cdev device Yi Liu
2023-05-13 13:21 ` Yi Liu
2023-05-13 13:21 ` [Intel-gfx] [PATCH v5 01/10] vfio-iommufd: Create iommufd_access for noiommu devices Yi Liu
2023-05-13 13:21 ` Yi Liu
2023-05-17 17:26 ` [Intel-gfx] " Alex Williamson
2023-05-17 17:26 ` Alex Williamson
2023-05-17 18:20 ` Jason Gunthorpe [this message]
2023-05-17 18:20 ` Jason Gunthorpe
2023-05-18 12:23 ` [Intel-gfx] " Liu, Yi L
2023-05-18 12:23 ` Liu, Yi L
2023-05-18 19:43 ` [Intel-gfx] " Alex Williamson
2023-05-18 19:43 ` Alex Williamson
2023-05-13 13:21 ` [Intel-gfx] [PATCH v5 02/10] vfio/pci: Update comment around group_fd get in vfio_pci_ioctl_pci_hot_reset() Yi Liu
2023-05-13 13:21 ` Yi Liu
2023-05-13 13:21 ` [Intel-gfx] [PATCH v5 03/10] vfio/pci: Move the existing hot reset logic to be a helper Yi Liu
2023-05-13 13:21 ` Yi Liu
2023-05-13 13:21 ` [Intel-gfx] [PATCH v5 04/10] vfio: Mark cdev usage in vfio_device Yi Liu
2023-05-13 13:21 ` Yi Liu
2023-05-13 13:21 ` [Intel-gfx] [PATCH v5 05/10] iommufd: Reserve all negative IDs in the iommufd xarray Yi Liu
2023-05-13 13:21 ` Yi Liu
2023-05-13 13:21 ` [Intel-gfx] [PATCH v5 06/10] vfio-iommufd: Add helper to retrieve iommufd_ctx and devid for vfio_device Yi Liu
2023-05-13 13:21 ` Yi Liu
2023-05-17 18:15 ` [Intel-gfx] " Alex Williamson
2023-05-17 18:15 ` Alex Williamson
2023-05-17 18:22 ` [Intel-gfx] " Jason Gunthorpe
2023-05-17 18:22 ` Jason Gunthorpe
2023-05-17 18:40 ` [Intel-gfx] " Alex Williamson
2023-05-17 18:40 ` Alex Williamson
2023-05-17 18:43 ` [Intel-gfx] " Jason Gunthorpe
2023-05-17 18:43 ` Jason Gunthorpe
2023-05-18 13:25 ` [Intel-gfx] " Liu, Yi L
2023-05-18 13:25 ` Liu, Yi L
2023-05-18 19:50 ` [Intel-gfx] " Alex Williamson
2023-05-18 19:50 ` Alex Williamson
2023-05-19 7:57 ` [Intel-gfx] " Tian, Kevin
2023-05-19 7:57 ` Tian, Kevin
2023-05-13 13:21 ` [Intel-gfx] [PATCH v5 07/10] vfio: Add helper to search vfio_device in a dev_set Yi Liu
2023-05-13 13:21 ` Yi Liu
2023-05-15 7:11 ` [Intel-gfx] " Cédric Le Goater
2023-05-15 7:11 ` Cédric Le Goater
2023-05-17 19:12 ` [Intel-gfx] " Alex Williamson
2023-05-17 19:12 ` Alex Williamson
2023-05-18 12:31 ` [Intel-gfx] " Liu, Yi L
2023-05-18 12:31 ` Liu, Yi L
2023-05-18 19:45 ` [Intel-gfx] " Alex Williamson
2023-05-18 19:45 ` Alex Williamson
2023-05-13 13:21 ` [Intel-gfx] [PATCH v5 08/10] iommufd: Add iommufd_ctx_has_group() Yi Liu
2023-05-13 13:21 ` Yi Liu
2023-05-17 19:40 ` [Intel-gfx] " Alex Williamson
2023-05-17 19:40 ` Alex Williamson
2023-05-18 12:33 ` [Intel-gfx] " Liu, Yi L
2023-05-18 12:33 ` Liu, Yi L
2023-05-13 13:21 ` [Intel-gfx] [PATCH v5 09/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev Yi Liu
2023-05-13 13:21 ` Yi Liu
2023-05-13 16:51 ` kernel test robot
2023-05-15 7:29 ` [Intel-gfx] " Cédric Le Goater
2023-05-15 7:29 ` Cédric Le Goater
2023-05-15 7:47 ` [Intel-gfx] " Liu, Yi L
2023-05-15 7:47 ` Liu, Yi L
2023-05-17 22:01 ` [Intel-gfx] " Alex Williamson
2023-05-17 22:01 ` Alex Williamson
2023-05-18 13:21 ` [Intel-gfx] " Liu, Yi L
2023-05-18 13:21 ` Liu, Yi L
2023-05-18 13:31 ` [Intel-gfx] " Liu, Yi L
2023-05-18 13:31 ` Liu, Yi L
2023-05-18 19:53 ` [Intel-gfx] " Alex Williamson
2023-05-18 19:53 ` Alex Williamson
2023-05-18 20:02 ` [Intel-gfx] " Alex Williamson
2023-05-18 20:02 ` Alex Williamson
2023-05-13 13:21 ` [Intel-gfx] [PATCH v5 10/10] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET Yi Liu
2023-05-13 13:21 ` Yi Liu
2023-05-13 14:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enhance vfio PCI hot reset for vfio cdev device (rev2) Patchwork
2023-05-13 18:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-05-13 20:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-05-17 22:09 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Enhance vfio PCI hot reset for vfio cdev device (rev3) Patchwork
2023-05-18 5:51 ` [Intel-gfx] [PATCH v5 00/10] Enhance vfio PCI hot reset for vfio cdev device Xu, Terrence
2023-05-18 5:51 ` Xu, Terrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGUbAzl985p5kX1Z@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=clegoate@redhat.com \
--cc=cohuck@redhat.com \
--cc=eric.auger@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jasowang@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=peterx@redhat.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=terrence.xu@intel.com \
--cc=xudong.hao@intel.com \
--cc=yan.y.zhao@intel.com \
--cc=yanting.jiang@intel.com \
--cc=yi.l.liu@intel.com \
--cc=yi.y.sun@linux.intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.