From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Tejus GK <tejus.gk@nutanix.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, peterx@redhat.com,
leobras@redhat.com, shivam.kumar1@nutanix.com
Subject: Re: [RFC v3 1/2] migration: Update error description whenever migration fails
Date: Thu, 18 May 2023 13:24:01 +0100 [thread overview]
Message-ID: <ZGYY4T/r4I4z0FRu@redhat.com> (raw)
In-Reply-To: <20230518062308.90631-2-tejus.gk@nutanix.com>
On Thu, May 18, 2023 at 06:23:07AM +0000, Tejus GK wrote:
> There are places in migration.c where the migration is marked failed with
> MIGRATION_STATUS_FAILED, but the failure reason is never updated. Hence
> libvirt doesn't know why the migration failed when it queries for it.
>
> Signed-off-by: Tejus GK <tejus.gk@nutanix.com>
> ---
> migration/migration.c | 23 ++++++++++++-----------
> 1 file changed, 12 insertions(+), 11 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-05-18 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 6:23 [RFC v3 0/2] migration: Update error description whenever migration fails Tejus GK
2023-05-18 6:23 ` [RFC v3 1/2] " Tejus GK
2023-05-18 11:50 ` Juan Quintela
2023-05-18 12:24 ` Daniel P. Berrangé [this message]
2023-05-18 6:23 ` [RFC v3 2/2] " Tejus GK
2023-05-18 11:52 ` Juan Quintela
2023-05-18 14:24 ` Tejus GK
2023-05-18 11:53 ` [RFC v3 0/2] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGYY4T/r4I4z0FRu@redhat.com \
--to=berrange@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shivam.kumar1@nutanix.com \
--cc=tejus.gk@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.