From: Simon Horman <simon.horman@corigine.com>
To: wei.fang@nxp.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, Frank.Li@freescale.com, shenwei.wang@nxp.com,
xiaoning.wang@nxp.com, netdev@vger.kernel.org, linux-imx@nxp.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: fec: remove useless fec_enet_reset_skb()
Date: Thu, 18 May 2023 19:17:45 +0200 [thread overview]
Message-ID: <ZGZduVeDx9TvlToT@corigine.com> (raw)
In-Reply-To: <20230518130016.1615671-1-wei.fang@nxp.com>
On Thu, May 18, 2023 at 09:00:16PM +0800, wei.fang@nxp.com wrote:
> From: Wei Fang <wei.fang@nxp.com>
>
> This patch is a cleanup for fec driver. The fec_enet_reset_skb()
> is used to free skb buffers for tx queues and is only invoked in
> fec_restart(). However, fec_enet_bd_init() also resets skb buffers
> and is invoked in fec_restart() too. So fec_enet_reset_skb() is
> redundant and useless.
>
> Fixes: 59d0f7465644 ("net: fec: init multi queue date structure")
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
Hi Wei Fang,
this change looks fine to me.
But it feels much more like a cleanup than a fix to me:
what user-visible problem is it fixing?
If so, I suggest targeting against net-next without the fixes tag.
next prev parent reply other threads:[~2023-05-18 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 13:00 [PATCH net] net: fec: remove useless fec_enet_reset_skb() wei.fang
2023-05-18 17:17 ` Simon Horman [this message]
2023-05-19 1:26 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGZduVeDx9TvlToT@corigine.com \
--to=simon.horman@corigine.com \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.