From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, marcandre.lureau@redhat.com,
richard.henderson@linaro.org, peter.maydell@linaro.org
Subject: Re: [PATCH 5/6] configure: rename --enable-pypi to --enable-download, control subprojects too
Date: Fri, 19 May 2023 10:07:40 +0100 [thread overview]
Message-ID: <ZGc8XCDoR+803blJ@redhat.com> (raw)
In-Reply-To: <20230519085647.1104775-6-pbonzini@redhat.com>
On Fri, May 19, 2023 at 10:56:45AM +0200, Paolo Bonzini wrote:
> The behavior of --{enable,disable}-pypi is similar to that of
> -Dwrapmode={default,nodownload} respectively. In particular,
> in both cases a feature needs to be explicitly enabled for the
> dependency to be downloaded.
>
> So, use a single option to control both cases. Now, --enable-slirp
> will trigger cloning and building of libslirp if the .pc file
> is not found on the machine.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> .gitignore | 2 --
> configure | 17 +++++++----------
> subprojects/.gitignore | 3 +++
> 3 files changed, 10 insertions(+), 12 deletions(-)
> create mode 100644 subprojects/.gitignore
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-05-19 9:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 8:56 [PATCH v2 0/6] meson: use subprojects for bundled projects Paolo Bonzini
2023-05-19 8:56 ` [PATCH 1/6] remove remaining traces of meson submodule Paolo Bonzini
2023-05-19 9:02 ` Daniel P. Berrangé
2023-05-19 8:56 ` [PATCH 2/6] meson: simplify logic for -Dfdt Paolo Bonzini
2023-05-19 9:04 ` Daniel P. Berrangé
2023-05-19 8:56 ` [PATCH 3/6] meson: use subproject for internal libfdt Paolo Bonzini
2023-05-19 9:05 ` Daniel P. Berrangé
2023-05-19 8:56 ` [PATCH 4/6] meson: use subproject for keycodemapdb Paolo Bonzini
2023-05-19 9:06 ` Daniel P. Berrangé
2023-05-19 8:56 ` [PATCH 5/6] configure: rename --enable-pypi to --enable-download, control subprojects too Paolo Bonzini
2023-05-19 9:07 ` Daniel P. Berrangé [this message]
2023-05-19 8:56 ` [PATCH 6/6] meson: subprojects: replace submodules with wrap files Paolo Bonzini
2023-05-19 9:25 ` Daniel P. Berrangé
2023-05-19 9:36 ` Paolo Bonzini
2023-05-19 9:21 ` [PATCH v2 0/6] meson: use subprojects for bundled projects Peter Maydell
2023-05-19 9:28 ` Paolo Bonzini
2023-05-19 9:32 ` Daniel P. Berrangé
2023-05-19 9:38 ` Peter Maydell
2023-05-19 9:40 ` Paolo Bonzini
2023-05-19 11:48 ` Paolo Bonzini
2023-05-24 7:51 ` Thomas Huth
2023-05-19 9:30 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGc8XCDoR+803blJ@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.