From: Sukrut Bellary <sukrut.bellary@linux.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Abel Vesa <abel.vesa@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Amol Maheshwari <amahesh@qti.qualcomm.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] misc: fastrpc: Fix double free of 'buf' in error path
Date: Thu, 18 May 2023 23:12:37 -0700 [thread overview]
Message-ID: <ZGcTVfAQeRcOSjO8@dev-linux.lan> (raw)
In-Reply-To: <28c6814d-1863-41fa-a471-35a3ccf4447c@kili.mountain>
On Fri, May 19, 2023 at 07:16:14AM +0300, Dan Carpenter wrote:
> On Thu, May 18, 2023 at 07:45:22PM -0700, Sukrut Bellary wrote:
> > > >
> > > > Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> > > > Signed-off-by: Sukrut Bellary <sukrut.bellary@linux.com>
> > > > ---
> > > ^^^
> > > Put testing caveats here instead, where it will be removed from the
> > > git log.
> > >
> >
> > Shall I add "This is based on static analysis only. Compilation tested"
> > here
> > or
> > is it not required to mention this for all the fixes?
> > Can you please recommend what's is the preferred method I need to follow?
>
> You can't go wrong with always adding it. The untested part is useful
> to know. Also it's good to know how a bug is found so we can say if
> it's affecting user and so we can improve our processes going forward.
>
Ok, that's clear. Thanks for the input.
Regards,
Sukrut Bellary
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2023-05-19 6:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 10:08 [PATCH] misc: fastrpc: Fix double free of 'buf' in error path Sukrut Bellary
2023-05-18 10:55 ` Dan Carpenter
2023-05-19 2:45 ` Sukrut Bellary
2023-05-19 4:16 ` Dan Carpenter
2023-05-19 6:12 ` Sukrut Bellary [this message]
2023-05-19 9:52 ` Srinivas Kandagatla
2023-05-19 10:22 ` Dan Carpenter
2023-05-19 10:39 ` Srinivas Kandagatla
2023-05-19 22:57 ` Sukrut Bellary
2023-06-01 4:45 ` Sukrut Bellary
2023-06-01 7:00 ` Dan Carpenter
2023-06-01 19:09 ` Sukrut Bellary
2023-05-19 10:58 ` Dan Carpenter
2023-05-19 23:39 ` Sukrut Bellary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGcTVfAQeRcOSjO8@dev-linux.lan \
--to=sukrut.bellary@linux.com \
--cc=abel.vesa@linaro.org \
--cc=amahesh@qti.qualcomm.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.