From: Vinod Koul <vkoul@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Maxime Ripard <mripard@kernel.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] dmaengine: at_xdmac: fix potential Oops in at_xdmac_prep_interleaved()
Date: Fri, 19 May 2023 16:54:13 +0530 [thread overview]
Message-ID: <ZGdcXc7GdvoYnYzD@matsya> (raw)
In-Reply-To: <21282b66-9860-410a-83df-39c17fcf2f1b@kili.mountain>
On 15-05-23, 13:32, Dan Carpenter wrote:
> There are two place if the at_xdmac_interleaved_queue_desc() fails which
> could lead to a NULL dereference where "first" is NULL and we call
> list_add_tail(&first->desc_node, ...). In the first caller, the return
> is not checked so add a check for that. In the next caller, the return
> is checked but if it fails on the first iteration through the loop then
> it will lead to a NULL pointer dereference.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2023-05-19 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 10:32 [PATCH] dmaengine: at_xdmac: fix potential Oops in at_xdmac_prep_interleaved() Dan Carpenter
2023-05-17 7:35 ` Tudor Ambarus
2023-05-19 11:24 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGdcXc7GdvoYnYzD@matsya \
--to=vkoul@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=mripard@kernel.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.