From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Lukasz Majewski <lukma@denx.de>
Cc: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/3] dsa: marvell: Define .set_max_frame_size() function for mv88e6250 SoC family
Date: Tue, 23 May 2023 15:38:10 +0100 [thread overview]
Message-ID: <ZGzP0qEjQkCFnXnr@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230523142912.2086985-2-lukma@denx.de>
On Tue, May 23, 2023 at 04:29:10PM +0200, Lukasz Majewski wrote:
> Switches from mv88e6250 family (the marketing name - "Link Street",
> including mv88e6020 and mv88e6071) need the possibility to setup the
> maximal frame size, as they support frames up to 2048 bytes.
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Adding this function doesn't allow the "possibility" for a larger frame
size. Adding it changes the value returned from mv88e6xxx_get_max_mtu()
to be a larger frame size, so all switches that make use of
mv88e6250_ops will be expected to support this larger frame size. Do
we know whether that is true?
There were patches floating about a while ago that specified the
maximum size in struct mv88e6xxx_info, but it seems those died a death.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-05-23 14:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 14:29 [PATCH v7 0/3] dsa: marvell: Add support for mv88e6071 and 6020 switches Lukasz Majewski
2023-05-23 14:29 ` [PATCH v7 1/3] dsa: marvell: Define .set_max_frame_size() function for mv88e6250 SoC family Lukasz Majewski
2023-05-23 14:38 ` Russell King (Oracle) [this message]
2023-05-24 12:53 ` Lukasz Majewski
2023-05-23 14:43 ` Russell King (Oracle)
2023-05-24 12:06 ` Lukasz Majewski
2023-05-24 12:08 ` Russell King (Oracle)
2023-05-23 14:29 ` [PATCH v7 2/3] net: dsa: mv88e6xxx: add support for MV88E6020 switch Lukasz Majewski
2023-05-23 14:29 ` [PATCH v7 3/3] net: dsa: mv88e6xxx: add support for MV88E6071 switch Lukasz Majewski
2023-05-23 17:37 ` Andrew Lunn
2023-05-23 17:26 ` [PATCH v7 0/3] dsa: marvell: Add support for mv88e6071 and 6020 switches Andrew Lunn
2023-05-24 12:17 ` Lukasz Majewski
2023-05-24 12:37 ` Russell King (Oracle)
2023-05-24 13:48 ` Andrew Lunn
2023-05-29 9:02 ` Lukasz Majewski
2023-05-29 10:51 ` Vladimir Oltean
2023-05-29 11:03 ` Lukasz Majewski
2023-05-29 11:23 ` Vladimir Oltean
2023-05-29 14:16 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGzP0qEjQkCFnXnr@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexander.duyck@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.