From: Peter Xu <peterx@redhat.com>
To: "Wang, Wei W" <wei.w.wang@intel.com>
Cc: "quintela@redhat.com" <quintela@redhat.com>,
"Wang, Lei4" <lei4.wang@intel.com>,
"berrange@redhat.com" <berrange@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming
Date: Tue, 23 May 2023 10:50:06 -0400 [thread overview]
Message-ID: <ZGzSnr5eaS1Wsjwf@x1n> (raw)
In-Reply-To: <DS0PR11MB637381609AFD7DA4998AB201DC409@DS0PR11MB6373.namprd11.prod.outlook.com>
On Tue, May 23, 2023 at 02:30:25PM +0000, Wang, Wei W wrote:
> > It's about whether we want to protect e.g. below steps:
> >
> > 1. start dest qemu with -incoming defer
> > 2. "migrate-set-capabilities" to enable multifd
> > 3. "migrate-incoming xxx" to setup the sockets
> > 4. "migrate-set-parameters" to setup the num of multifd <--- will be invalid here
>
> Yes, step 4 is invalid, but I think nobody cares about that (i.e. no place uses the
> invalid value) as step2 already fails the cap setting (with error messages).
Since only until step 3 it setups the transport_data, so step 2 should be
fine and not fail? That's the whole point of my example or I missd
something here..
--
Peter Xu
next prev parent reply other threads:[~2023-05-23 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 16:00 [PATCH v1] migration: fail the cap check if it requires the use of deferred incoming Wei Wang
2023-05-18 19:20 ` Peter Xu
2023-05-19 2:34 ` Wang, Wei W
2023-05-19 15:30 ` Peter Xu
2023-05-19 15:33 ` Peter Xu
2023-05-20 1:42 ` Wang, Wei W
2023-05-22 23:36 ` Peter Xu
2023-05-23 1:44 ` Wang, Wei W
2023-05-23 13:40 ` Peter Xu
2023-05-23 14:30 ` Wang, Wei W
2023-05-23 14:50 ` Peter Xu [this message]
2023-05-24 1:47 ` Wang, Wei W
2023-05-19 8:26 ` Daniel P. Berrangé
2023-05-19 15:31 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGzSnr5eaS1Wsjwf@x1n \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=lei4.wang@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.