From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: David Epping <david.epping@missinglinkelectronics.com>
Cc: Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net v3 3/4] net: phy: mscc: remove unnecessary phydev locking
Date: Tue, 23 May 2023 16:32:44 +0100 [thread overview]
Message-ID: <ZGzcnFuhapF/h0lt@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230523153108.18548-4-david.epping@missinglinkelectronics.com>
On Tue, May 23, 2023 at 05:31:07PM +0200, David Epping wrote:
> Holding the struct phy_device (phydev) lock is unnecessary when
> accessing phydev->interface in the PHY driver .config_init method,
> which is the only place that vsc85xx_rgmii_set_skews() is called from.
>
> The phy_modify_paged() function implements required MDIO bus level
> locking, which can not be achieved by a phydev lock.
>
> Signed-off-by: David Epping <david.epping@missinglinkelectronics.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-05-23 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 15:31 [PATCH net v3 0/4] net: phy: mscc: support VSC8501 David Epping
2023-05-23 15:31 ` [PATCH net v3 1/4] net: phy: mscc: add VSC8502 to MODULE_DEVICE_TABLE David Epping
2023-05-23 15:31 ` [PATCH net v3 2/4] net: phy: mscc: add support for VSC8501 David Epping
2023-05-23 15:31 ` [PATCH net v3 3/4] net: phy: mscc: remove unnecessary phydev locking David Epping
2023-05-23 15:32 ` Russell King (Oracle) [this message]
2023-05-23 15:31 ` [PATCH net v3 4/4] net: phy: mscc: enable VSC8501/2 RGMII RX clock David Epping
2023-05-23 15:33 ` Russell King (Oracle)
2023-05-24 23:05 ` Vladimir Oltean
2023-05-25 5:20 ` [PATCH net v3 0/4] net: phy: mscc: support VSC8501 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGzcnFuhapF/h0lt@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=david.epping@missinglinkelectronics.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.