From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Markus Schneider-Pargmann <msp@baylibre.com>,
linux-input@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 1/2] Input: tps65219-pwrbutton - Convert to .remove_new()
Date: Tue, 6 Jun 2023 12:12:44 -0700 [thread overview]
Message-ID: <ZH+FLCkoHZQckbni@google.com> (raw)
In-Reply-To: <20230605161458.117361-1-u.kleine-koenig@pengutronix.de>
On Mon, Jun 05, 2023 at 06:14:57PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning).
>
> To improve here there is a quest to make the remove callback return void.
> In the first step of this quest all drivers are converted to .remove_new()
> which already returns void. Eventually after all drivers are converted,
> .remove_new() is renamed to .remove().
>
> Before this driver might have returned an error. In this case emit a
> warning that tells more about the problem than the generic warning by
> the core, and instead of making the remove callback return zero
> unconditionally, convert to .remove_new() which is equivalent.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2023-06-06 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 16:14 [PATCH 1/2] Input: tps65219-pwrbutton - Convert to .remove_new() Uwe Kleine-König
2023-06-05 16:14 ` [PATCH 2/2] Input: tps65219-pwrbutton - Use regmap_set_bits() Uwe Kleine-König
2023-06-06 9:20 ` Markus Schneider-Pargmann
2023-06-06 19:12 ` Dmitry Torokhov
2023-06-06 9:19 ` [PATCH 1/2] Input: tps65219-pwrbutton - Convert to .remove_new() Markus Schneider-Pargmann
2023-06-06 19:12 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH+FLCkoHZQckbni@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-input@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.