From: Christoph Hellwig <hch@infradead.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
Wang Yugui <wangyugui@e16-tech.com>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
"Darrick J . Wong" <djwong@kernel.org>
Subject: Re: [PATCH v2 3/7] iomap: Remove unnecessary test from iomap_release_folio()
Date: Mon, 5 Jun 2023 00:13:18 -0700 [thread overview]
Message-ID: <ZH2LDjrBjajOSDB+@infradead.org> (raw)
In-Reply-To: <20230602222445.2284892-4-willy@infradead.org>
> - * dirty folios to ->release_folio() via shrink_active_list();
> - * skip those here.
> + * If the folio is dirty, we refuse to release our metadata because
> + * it may be partially dirty (FIXME, add a test for that).
I'd prefer not to add this FIXME as we're fine without the per-block
dirty tracking.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-06-05 7:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 22:24 [PATCH v2 0/7] Create large folios in iomap buffered write path Matthew Wilcox (Oracle)
2023-06-02 22:24 ` [PATCH v2 1/7] iomap: Remove large folio handling in iomap_invalidate_folio() Matthew Wilcox (Oracle)
2023-06-04 17:58 ` Darrick J. Wong
2023-06-05 7:11 ` Christoph Hellwig
2023-06-02 22:24 ` [PATCH v2 2/7] doc: Correct the description of ->release_folio Matthew Wilcox (Oracle)
2023-06-04 17:55 ` Darrick J. Wong
2023-06-04 20:10 ` Matthew Wilcox
2023-06-04 20:33 ` Darrick J. Wong
2023-06-05 13:11 ` Matthew Wilcox
2023-06-05 15:07 ` Darrick J. Wong
2023-06-05 7:12 ` Christoph Hellwig
2023-06-02 22:24 ` [PATCH v2 3/7] iomap: Remove unnecessary test from iomap_release_folio() Matthew Wilcox (Oracle)
2023-06-04 18:01 ` Darrick J. Wong
2023-06-04 21:39 ` Matthew Wilcox
2023-06-05 21:10 ` Ritesh Harjani
2023-06-05 7:13 ` Christoph Hellwig [this message]
2023-06-02 22:24 ` [PATCH v2 4/7] filemap: Add fgp_t typedef Matthew Wilcox (Oracle)
2023-06-04 18:02 ` Darrick J. Wong
2023-06-05 7:14 ` Christoph Hellwig
2023-06-02 22:24 ` [PATCH v2 5/7] filemap: Allow __filemap_get_folio to allocate large folios Matthew Wilcox (Oracle)
2023-06-04 18:09 ` Darrick J. Wong
2023-06-04 21:48 ` Matthew Wilcox
2023-06-05 15:21 ` Darrick J. Wong
2023-06-05 7:16 ` Christoph Hellwig
2023-06-02 22:24 ` [PATCH v2 6/7] iomap: Create large folios in the buffered write path Matthew Wilcox (Oracle)
2023-06-04 18:10 ` Darrick J. Wong
2023-06-05 7:16 ` Christoph Hellwig
2023-06-02 22:24 ` [PATCH v2 7/7] iomap: Copy larger chunks from userspace Matthew Wilcox (Oracle)
2023-06-04 18:29 ` Darrick J. Wong
2023-06-04 22:11 ` Matthew Wilcox
2023-06-05 8:25 ` Yin, Fengwei
2023-06-06 18:07 ` Matthew Wilcox
2023-06-07 2:21 ` Yin Fengwei
2023-06-07 5:33 ` Yin, Fengwei
2023-06-07 15:55 ` Matthew Wilcox
2023-06-08 1:22 ` Yin Fengwei
2023-06-07 6:40 ` Yin Fengwei
2023-06-07 15:56 ` Matthew Wilcox
2023-06-04 0:19 ` [PATCH v2 0/7] Create large folios in iomap buffered write path Wang Yugui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH2LDjrBjajOSDB+@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=wangyugui@e16-tech.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.