From: Stanislav Fomichev <sdf@google.com>
To: Xin Liu <liuxin350@huawei.com>
Cc: daniel@iogearbox.net, andrii@kernel.org, ast@kernel.org,
bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
hsinweih@uci.edu, jakub@cloudflare.com,
john.fastabend@gmail.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com,
syzbot+49f6cef45247ff249498@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com, yanan@huawei.com,
wuchangye@huawei.com, xiesongyang@huawei.com,
kongweibin2@huawei.com, zhangmingyi5@huawei.com
Subject: Re: [PATCH] libbpf:fix use empty function pointers in ringbuf_poll
Date: Mon, 5 Jun 2023 10:26:46 -0700 [thread overview]
Message-ID: <ZH4a1l1pfG8ewo3v@google.com> (raw)
In-Reply-To: <20230605033449.239123-1-liuxin350@huawei.com>
On 06/05, Xin Liu wrote:
> From: zhangmingyi <zhangmingyi5@huawei.com>
>
> The sample_cb of the ring_buffer__new interface can transfer NULL. However,
> the system does not check whether sample_cb is NULL during
> ring_buffer__poll, null pointer is used.
What is the point of calling ring_buffer__new with sample_cb == NULL?
next prev parent reply other threads:[~2023-06-05 17:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 3:34 [PATCH] libbpf:fix use empty function pointers in ringbuf_poll Xin Liu
2023-06-05 17:26 ` Stanislav Fomichev [this message]
2023-06-08 12:58 ` zhangmingyi
2023-06-08 16:27 ` Stanislav Fomichev
2023-06-08 17:38 ` Andrii Nakryiko
2023-06-09 9:36 ` zhangmingyi
2023-06-09 16:55 ` Stanislav Fomichev
2023-06-09 18:23 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH4a1l1pfG8ewo3v@google.com \
--to=sdf@google.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hsinweih@uci.edu \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=kongweibin2@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuxin350@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+49f6cef45247ff249498@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=wuchangye@huawei.com \
--cc=xiesongyang@huawei.com \
--cc=yanan@huawei.com \
--cc=zhangmingyi5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.