From: Jiri Olsa <olsajiri@gmail.com>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Alexei Starovoitov <ast@kernel.org>
Subject: Re: [linux-next:master 2368/6966] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:330:18: warning: no previous prototype for 'bpf_kfunc_call_test_offset'
Date: Mon, 5 Jun 2023 23:00:20 +0200 [thread overview]
Message-ID: <ZH5M5HZSi0bTdzaj@krava> (raw)
In-Reply-To: <ZH2I8W2aUkJyPliD@krava>
On Mon, Jun 05, 2023 at 09:04:21AM +0200, Jiri Olsa wrote:
> On Mon, Jun 05, 2023 at 01:50:10PM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: bc708bbd8260ee4eb3428b0109f5f3be661fae46
> > commit: 65eb006d85a2ac0b23464808099726bd826e9877 [2368/6966] bpf: Move kernel test kfuncs to bpf_testmod
> > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> > reproduce:
> > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=65eb006d85a2ac0b23464808099726bd826e9877
> > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> > git fetch --no-tags linux-next master
> > git checkout 65eb006d85a2ac0b23464808099726bd826e9877
> > make O=/tmp/kselftest headers
> > make O=/tmp/kselftest -C tools/testing/selftests
> >
> > If you fix the issue, kindly add following tag where applicable
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202306051319.EihCQZPs-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:199:1: warning: no previous prototype for 'bpf_testmod_test_read' [-Wmissing-prototypes]
> > 199 | bpf_testmod_test_read(struct file *file, struct kobject *kobj,
> > | ^~~~~~~~~~~~~~~~~~~~~
> > tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:259:1: warning: no previous prototype for 'bpf_testmod_test_write' [-Wmissing-prototypes]
> > 259 | bpf_testmod_test_write(struct file *file, struct kobject *kobj,
> > | ^~~~~~~~~~~~~~~~~~~~~~
> > >> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:330:18: warning: no previous prototype for 'bpf_kfunc_call_test_offset' [-Wmissing-prototypes]
> > 330 | __bpf_kfunc void bpf_kfunc_call_test_offset(struct prog_test_ref_kfunc *p)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > >> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:336:1: warning: no previous prototype for 'bpf_kfunc_call_memb_acquire' [-Wmissing-prototypes]
> > 336 | bpf_kfunc_call_memb_acquire(void)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:342:18: warning: no previous prototype for 'bpf_kfunc_call_memb1_release' [-Wmissing-prototypes]
> > 342 | __bpf_kfunc void bpf_kfunc_call_memb1_release(struct prog_test_member1 *p)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:394:18: warning: no previous prototype for 'bpf_kfunc_call_test_fail1' [-Wmissing-prototypes]
> > 394 | __bpf_kfunc void bpf_kfunc_call_test_fail1(struct prog_test_fail1 *p)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > >> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:398:18: warning: no previous prototype for 'bpf_kfunc_call_test_fail2' [-Wmissing-prototypes]
> > 398 | __bpf_kfunc void bpf_kfunc_call_test_fail2(struct prog_test_fail2 *p)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > >> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:402:18: warning: no previous prototype for 'bpf_kfunc_call_test_fail3' [-Wmissing-prototypes]
> > 402 | __bpf_kfunc void bpf_kfunc_call_test_fail3(struct prog_test_fail3 *p)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~
> > >> tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:410:18: warning: no previous prototype for 'bpf_kfunc_call_test_mem_len_fail1' [-Wmissing-prototypes]
> > 410 | __bpf_kfunc void bpf_kfunc_call_test_mem_len_fail1(void *mem, int len)
> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:465:14: warning: no previous prototype for 'bpf_fentry_shadow_test' [-Wmissing-prototypes]
> > 465 | noinline int bpf_fentry_shadow_test(int a)
> > | ^~~~~~~~~~~~~~~~~~~~~~
>
> hi,
> I can't reprduce, not event the old warnings..
> is there perhaps specific .config you use for the kernel?
ah ok, just make W=1 will do that
I think we can add most of them to bpf_testmod_kfunc.h
will send patch
jirka
next prev parent reply other threads:[~2023-06-05 21:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 5:50 [linux-next:master 2368/6966] tools/testing/selftests/bpf/bpf_testmod/bpf_testmod.c:330:18: warning: no previous prototype for 'bpf_kfunc_call_test_offset' kernel test robot
2023-06-05 7:04 ` Jiri Olsa
2023-06-05 21:00 ` Jiri Olsa [this message]
2023-06-06 6:28 ` Liu, Yujie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH5M5HZSi0bTdzaj@krava \
--to=olsajiri@gmail.com \
--cc=ast@kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.