From: Simon Horman <simon.horman@corigine.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
Patrisious Haddad <phaddad@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Raed Salem <raeds@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>,
Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH net 2/4] net/mlx5e: Fix ESN update kernel panic
Date: Tue, 6 Jun 2023 11:08:18 +0200 [thread overview]
Message-ID: <ZH73gi4JgGu1MZkD@corigine.com> (raw)
In-Reply-To: <acc45e30ff0cf5220a3fda02411d22880878102f.1685950599.git.leonro@nvidia.com>
On Mon, Jun 05, 2023 at 11:09:50AM +0300, Leon Romanovsky wrote:
> From: Patrisious Haddad <phaddad@nvidia.com>
>
> Previously during mlx5e_ipsec_handle_event the driver tried to execute
> an operation that could sleep, while holding a spinlock, which caused
> the kernel panic mentioned below.
>
> Move the function call that can sleep outside of the spinlock context.
>
> Call Trace:
> <TASK>
> dump_stack_lvl+0x49/0x6c
> __schedule_bug.cold+0x42/0x4e
> schedule_debug.constprop.0+0xe0/0x118
> __schedule+0x59/0x58a
> ? __mod_timer+0x2a1/0x3ef
> schedule+0x5e/0xd4
> schedule_timeout+0x99/0x164
> ? __pfx_process_timeout+0x10/0x10
> __wait_for_common+0x90/0x1da
> ? __pfx_schedule_timeout+0x10/0x10
> wait_func+0x34/0x142 [mlx5_core]
> mlx5_cmd_invoke+0x1f3/0x313 [mlx5_core]
> cmd_exec+0x1fe/0x325 [mlx5_core]
> mlx5_cmd_do+0x22/0x50 [mlx5_core]
> mlx5_cmd_exec+0x1c/0x40 [mlx5_core]
> mlx5_modify_ipsec_obj+0xb2/0x17f [mlx5_core]
> mlx5e_ipsec_update_esn_state+0x69/0xf0 [mlx5_core]
> ? wake_affine+0x62/0x1f8
> mlx5e_ipsec_handle_event+0xb1/0xc0 [mlx5_core]
> process_one_work+0x1e2/0x3e6
> ? __pfx_worker_thread+0x10/0x10
> worker_thread+0x54/0x3ad
> ? __pfx_worker_thread+0x10/0x10
> kthread+0xda/0x101
> ? __pfx_kthread+0x10/0x10
> ret_from_fork+0x29/0x37
> </TASK>
> BUG: workqueue leaked lock or atomic: kworker/u256:4/0x7fffffff/189754#012 last function: mlx5e_ipsec_handle_event [mlx5_core]
> CPU: 66 PID: 189754 Comm: kworker/u256:4 Kdump: loaded Tainted: G W 6.2.0-2596.20230309201517_5.el8uek.rc1.x86_64 #2
> Hardware name: Oracle Corporation ORACLE SERVER X9-2/ASMMBX9-2, BIOS 61070300 08/17/2022
> Workqueue: mlx5e_ipsec: eth%d mlx5e_ipsec_handle_event [mlx5_core]
> Call Trace:
> <TASK>
> dump_stack_lvl+0x49/0x6c
> process_one_work.cold+0x2b/0x3c
> ? __pfx_worker_thread+0x10/0x10
> worker_thread+0x54/0x3ad
> ? __pfx_worker_thread+0x10/0x10
> kthread+0xda/0x101
> ? __pfx_kthread+0x10/0x10
> ret_from_fork+0x29/0x37
> </TASK>
> BUG: scheduling while atomic: kworker/u256:4/189754/0x00000000
>
> Fixes: cee137a63431 ("net/mlx5e: Handle ESN update events")
> Signed-off-by: Patrisious Haddad <phaddad@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-06-06 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 8:09 [PATCH net 0/4] Fix mixing atomic/non-atomic contexts in mlx5 IPsec code Leon Romanovsky
2023-06-05 8:09 ` [PATCH net 1/4] net/mlx5e: Don't delay release of hardware objects Leon Romanovsky
2023-06-06 9:07 ` Simon Horman
2023-06-05 8:09 ` [PATCH net 2/4] net/mlx5e: Fix ESN update kernel panic Leon Romanovsky
2023-06-06 9:08 ` Simon Horman [this message]
2023-06-05 8:09 ` [PATCH net 3/4] net/mlx5e: Drop XFRM state lock when modifying flow steering Leon Romanovsky
2023-06-06 9:12 ` Simon Horman
2023-06-05 8:09 ` [PATCH net 4/4] net/mlx5e: Fix scheduling of IPsec ASO query while in atomic Leon Romanovsky
2023-06-06 9:13 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH73gi4JgGu1MZkD@corigine.com \
--to=simon.horman@corigine.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phaddad@nvidia.com \
--cc=raeds@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.